[
https://issues.apache.org/jira/browse/HIVE-24288?focusedWorklogId=505380&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-505380
]
ASF GitHub Bot logged work on HIVE-24288:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Oct/20 19:21
Start Date: 27/Oct/20 19:21
Worklog Time Spent: 10m
Work Description: yongzhi commented on a change in pull request #1590:
URL: https://github.com/apache/hive/pull/1590#discussion_r512948993
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/processors/CompileProcessor.java
##########
@@ -241,6 +255,14 @@ CommandProcessorResponse compile(SessionState ss) throws
CommandProcessorExcepti
out.closeArchiveEntry();
}
out.finish();
+ try {
+ Set<PosixFilePermission> perms = EnumSet.of(
+ PosixFilePermission.OWNER_READ,
Review comment:
Should the permission set at the files create time?
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/processors/CompileProcessor.java
##########
@@ -241,6 +255,14 @@ CommandProcessorResponse compile(SessionState ss) throws
CommandProcessorExcepti
out.closeArchiveEntry();
}
out.finish();
+ try {
+ Set<PosixFilePermission> perms = EnumSet.of(
+ PosixFilePermission.OWNER_READ,
+ PosixFilePermission.OWNER_WRITE);
+ Files.setPosixFilePermissions(Paths.get(testArchive.toURI()), perms);
+ } catch (IOException ioe) {
+ LOG.warn("Lockdown permissions could not be set for the jar archive.
JAR file could be open to other users depending on default FS permissions");
Review comment:
If the IOException here, can you still delete the file later(has the
permission)?
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/processors/CompileProcessor.java
##########
@@ -254,6 +276,9 @@ CommandProcessorResponse compile(SessionState ss) throws
CommandProcessorExcepti
if (ss != null){
ss.add_resource(ResourceType.JAR, testArchive.getAbsolutePath());
+ try {
+ testArchive.deleteOnExit();
Review comment:
Will this jar file be added several times to resource? If not, could it
is possible to just delete it and use what is in resource?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 505380)
Time Spent: 20m (was: 10m)
> Files created by CompileProcessor have incorrect permissions
> ------------------------------------------------------------
>
> Key: HIVE-24288
> URL: https://issues.apache.org/jira/browse/HIVE-24288
> Project: Hive
> Issue Type: Bug
> Components: Hive
> Affects Versions: 3.1.0
> Reporter: Naveen Gangam
> Assignee: Naveen Gangam
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Compile processor generates some temporary files as part of processing. These
> need to be cleaned up on exit from CLI.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
