[ 
https://issues.apache.org/jira/browse/HIVE-24180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17198441#comment-17198441
 ] 

Stamatis Zampetakis commented on HIVE-24180:
--------------------------------------------

After looking in the current implementation of the respective thread pool it 
appears that also the description of the property is wrong. The property gives 
the wrong impression that it bounds from above the number of threads that are 
used for heart beating. In fact, it bounds them from below since it defines the 
{{corePoolSize}} and not the {{maximumPoolSize}} which remains unbounded. 

On top of that I don't see a huge benefit making the {{corePoolSize}} of this 
thread pool configurable. 

For the reasons mentioned above, I would opt for removing entirely this 
configuration since it can also simplify a lot the respective code. If we 
decide to keep it then we have to fix at least the deprecation issue. 


> 'hive.txn.heartbeat.threadpool.size' is deprecated in HiveConf with no 
> alternative
> ----------------------------------------------------------------------------------
>
>                 Key: HIVE-24180
>                 URL: https://issues.apache.org/jira/browse/HIVE-24180
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Stamatis Zampetakis
>            Assignee: Stamatis Zampetakis
>            Priority: Major
>
> HiveConf.ConfVars#HIVE_TXN_HEARTBEAT_THREADPOOL_SIZE appears deprecated with 
> javadoc pointing to MetastoreConf.TXN_HEARTBEAT_THREADPOOL_SIZE but there is 
> no such configuration variable in MetastoreConf.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to