[ 
https://issues.apache.org/jira/browse/HIVE-23800?focusedWorklogId=484907&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-484907
 ]

ASF GitHub Bot logged work on HIVE-23800:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/Sep/20 03:48
            Start Date: 16/Sep/20 03:48
    Worklog Time Spent: 10m 
      Work Description: dengzhhu653 commented on a change in pull request #1205:
URL: https://github.com/apache/hive/pull/1205#discussion_r489144427



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/hooks/HookContext.java
##########
@@ -45,7 +47,50 @@
 public class HookContext {
 
   static public enum HookType {
-    PRE_EXEC_HOOK, POST_EXEC_HOOK, ON_FAILURE_HOOK
+
+    PRE_EXEC_HOOK(HiveConf.ConfVars.PREEXECHOOKS, ExecuteWithHookContext.class,
+        "Pre-execution hooks to be invoked for each statement"),
+    POST_EXEC_HOOK(HiveConf.ConfVars.POSTEXECHOOKS, 
ExecuteWithHookContext.class,
+        "Post-execution hooks to be invoked for each statement"),
+    ON_FAILURE_HOOK(HiveConf.ConfVars.ONFAILUREHOOKS, 
ExecuteWithHookContext.class,
+        "On-failure hooks to be invoked for each statement"),
+    QUERY_LIFETIME_HOOKS(HiveConf.ConfVars.HIVE_QUERY_LIFETIME_HOOKS, 
QueryLifeTimeHook.class,
+      "Hooks that will be triggered before/after query compilation and 
before/after query execution"),
+    SEMANTIC_ANALYZER_HOOK(HiveConf.ConfVars.SEMANTIC_ANALYZER_HOOK, 
HiveSemanticAnalyzerHook.class,
+      "Hooks that invoked before/after Hive performs its own semantic analysis 
on a statement"),
+    DRIVER_RUN_HOOKS(HiveConf.ConfVars.HIVE_DRIVER_RUN_HOOKS, 
HiveDriverRunHook.class,
+      "Hooks that Will be run at the beginning and end of Driver.run"),
+    REDACTOR(HiveConf.ConfVars.QUERYREDACTORHOOKS, Redactor.class,
+      "Hooks to be invoked for each query which can tranform the query before 
it's placed in the job.xml file"),
+    // The HiveSessionHook.class cannot access, use Hook.class instead
+    HIVE_SERVER2_SESSION_HOOK(HiveConf.ConfVars.HIVE_SERVER2_SESSION_HOOK, 
Hook.class,
+      "Hooks to be executed when session manager starts a new session"),
+    OOM(HiveConf.ConfVars.HIVE_SERVER2_OOM_HOOKS, Runnable.class,

Review comment:
       done, thank you




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 484907)
    Time Spent: 5h  (was: 4h 50m)

> Add hooks when HiveServer2 stops due to OutOfMemoryError
> --------------------------------------------------------
>
>                 Key: HIVE-23800
>                 URL: https://issues.apache.org/jira/browse/HIVE-23800
>             Project: Hive
>          Issue Type: Improvement
>          Components: HiveServer2
>            Reporter: Zhihua Deng
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 5h
>  Remaining Estimate: 0h
>
> Make oom hook an interface of HiveServer2,  so user can implement the hook to 
> do something before HS2 stops, such as dumping the heap or altering the 
> devops.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to