[
https://issues.apache.org/jira/browse/HIVE-24084?focusedWorklogId=480207&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-480207
]
ASF GitHub Bot logged work on HIVE-24084:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Sep/20 15:17
Start Date: 08/Sep/20 15:17
Worklog Time Spent: 10m
Work Description: kgyrtkirk commented on a change in pull request #1439:
URL: https://github.com/apache/hive/pull/1439#discussion_r485001912
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveAggregateJoinTransposeRule.java
##########
@@ -303,6 +305,90 @@ public void onMatch(RelOptRuleCall call) {
}
}
+ /**
+ * Determines weather the give grouping is unique.
+ *
+ * Consider a join which might produce non-unique rows; but later the
results are aggregated again.
+ * This method determines if there are sufficient columns in the grouping
which have been present previously as unique column(s).
+ */
+ private boolean isGroupingUnique(RelNode input, ImmutableBitSet groups) {
+ if (groups.isEmpty()) {
+ return false;
+ }
+ RelMetadataQuery mq = input.getCluster().getMetadataQuery();
+ Set<ImmutableBitSet> uKeys = mq.getUniqueKeys(input);
Review comment:
yes; I've explored using `areColumnsUnique` because it matches the
usecase here - however for some tests it emitted some NPEs so I've gone back to
the `getUniqueKeys` approach
I'll file a jira for `areColumnsUnique` when I know what's wrong with it..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 480207)
Time Spent: 2h 10m (was: 2h)
> Push Aggregates thru joins in case it re-groups previously unique columns
> -------------------------------------------------------------------------
>
> Key: HIVE-24084
> URL: https://issues.apache.org/jira/browse/HIVE-24084
> Project: Hive
> Issue Type: Improvement
> Reporter: Zoltan Haindrich
> Assignee: Zoltan Haindrich
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
