[ 
https://issues.apache.org/jira/browse/HIVE-11903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14908006#comment-14908006
 ] 

Yongzhi Chen commented on HIVE-11903:
-------------------------------------

For the zookeeper connections, HS2 does not have much:
1. The lock manager uses 1 (the singleton). This singleton change because of 
zookeeper connection leak issues before
2.  If we're supporting dynamic service discovery, there is one at HS2 startup. 
And the watcher related to HS2 and Zookeeper: DeRegisterWatcher is used to 
remove zookeeper node for the server if the server is removed from service 
discovery. 
This zookeeper connection will be removed when HS2 stops. 
3. The one is used in deleteServerInstancesFromZooKeeper, it is closed right 
after use within the method. 

Do you want to count connection for case 2 and 3 too? Or do you want to count 
other kind of connections? Thanks

> Add zookeeper metrics to HS2
> ----------------------------
>
>                 Key: HIVE-11903
>                 URL: https://issues.apache.org/jira/browse/HIVE-11903
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Diagnosability
>            Reporter: Szehon Ho
>            Assignee: Yongzhi Chen
>             Fix For: 1.3.0, 2.0.0
>
>         Attachments: HIVE-11903.1.patch, HIVE-11903.2.patch
>
>
> Potential metrics are active zookeeper connections, locks taken by type, etc. 
>  Can refine as we go along.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to