[
https://issues.apache.org/jira/browse/HIVE-23855?focusedWorklogId=461550&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-461550
]
ASF GitHub Bot logged work on HIVE-23855:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jul/20 12:36
Start Date: 21/Jul/20 12:36
Worklog Time Spent: 10m
Work Description: pgaref commented on a change in pull request #1277:
URL: https://github.com/apache/hive/pull/1277#discussion_r458061768
##########
File path:
service/src/test/org/apache/hadoop/util/ShutdownHookManagerInspector.java
##########
@@ -20,9 +20,20 @@
import java.util.List;
+import static org.junit.Assert.assertEquals;
+
public class ShutdownHookManagerInspector {
- public static List<ShutdownHookManager.HookEntry> getShutdownHooksInOrder() {
- return ShutdownHookManager.get().getShutdownHooksInOrder();
+ public static int getShutdownHookCount() {
+ return ShutdownHookManager.get().getShutdownHooksInOrder().size();
+ }
+
+ public static void assertShutdownHookCount(int expected) {
+ List<ShutdownHookManager.HookEntry> entries =
ShutdownHookManager.get().getShutdownHooksInOrder();
+ StringBuilder errorBuilder = new StringBuilder("Shutdown hooks:\n");
+ for (ShutdownHookManager.HookEntry entry: entries) {
Review comment:
nit: space before col
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 461550)
Time Spent: 40m (was: 0.5h)
> TestQueryShutdownHooks is flaky
> -------------------------------
>
> Key: HIVE-23855
> URL: https://issues.apache.org/jira/browse/HIVE-23855
> Project: Hive
> Issue Type: Bug
> Reporter: Zoltan Haindrich
> Assignee: Mustafa Iman
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> http://ci.hive.apache.org/job/hive-precommit/job/master/100/
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
