[
https://issues.apache.org/jira/browse/HIVE-23324?focusedWorklogId=461537&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-461537
]
ASF GitHub Bot logged work on HIVE-23324:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jul/20 11:32
Start Date: 21/Jul/20 11:32
Worklog Time Spent: 10m
Work Description: pvary commented on a change in pull request #1275:
URL: https://github.com/apache/hive/pull/1275#discussion_r458027913
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java
##########
@@ -64,13 +67,15 @@
static final private String CLASS_NAME = Cleaner.class.getName();
static final private Logger LOG = LoggerFactory.getLogger(CLASS_NAME);
private long cleanerCheckInterval = 0;
+ private Executor cleanerExecutor;
private ReplChangeManager replChangeManager;
@Override
public void init(AtomicBoolean stop) throws Exception {
super.init(stop);
replChangeManager = ReplChangeManager.getInstance(conf);
+ cleanerExecutor =
Executors.newFixedThreadPool(conf.getIntVar(HiveConf.ConfVars.HIVE_COMPACTOR_CLEANER_REQUEST_QUEUE));
Review comment:
I prefer the way how it was done in Worker.java:
- Named threads
- Priority down
- Set daemon on/off
- Stopped in finally
Shall we do it here, or should we create a follow-up jira for creating and
cleaning up the executor threads for Cleaner and Initiator as well?
Thanks,
Peter
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java
##########
@@ -64,13 +67,15 @@
static final private String CLASS_NAME = Cleaner.class.getName();
static final private Logger LOG = LoggerFactory.getLogger(CLASS_NAME);
private long cleanerCheckInterval = 0;
+ private Executor cleanerExecutor;
private ReplChangeManager replChangeManager;
@Override
public void init(AtomicBoolean stop) throws Exception {
super.init(stop);
replChangeManager = ReplChangeManager.getInstance(conf);
+ cleanerExecutor =
Executors.newFixedThreadPool(conf.getIntVar(HiveConf.ConfVars.HIVE_COMPACTOR_CLEANER_REQUEST_QUEUE));
Review comment:
I prefer the way how it was done in Worker.java:
- Named threads
- Priority down
- Set daemon on/off
- Stopped in finally
Shall we do it here, or should we create a follow-up jira for creating and
cleaning up the executor threads for Cleaner and Initiator as well?
Thanks,
Peter
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 461537)
Time Spent: 1h 10m (was: 1h)
> Parallelise compaction directory cleaning process
> -------------------------------------------------
>
> Key: HIVE-23324
> URL: https://issues.apache.org/jira/browse/HIVE-23324
> Project: Hive
> Issue Type: Improvement
> Reporter: Marton Bod
> Assignee: Adesh Kumar Rao
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Initiator processes the various compaction candidates in parallel, so we
> could follow a similar approach in Cleaner where we currently clean the
> directories sequentially.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
