[
https://issues.apache.org/jira/browse/HIVE-23850?focusedWorklogId=460079&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-460079
]
ASF GitHub Bot logged work on HIVE-23850:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Jul/20 04:00
Start Date: 17/Jul/20 04:00
Worklog Time Spent: 10m
Work Description: dengzhhu653 commented on a change in pull request #1255:
URL: https://github.com/apache/hive/pull/1255#discussion_r456205255
##########
File path: ql/src/test/queries/clientpositive/groupby_grouping_sets_pushdown1.q
##########
@@ -4,16 +4,51 @@ CREATE TABLE T1(a STRING, b STRING, s BIGINT);
INSERT OVERWRITE TABLE T1 VALUES ('aaa', 'bbb', 123456);
EXPLAIN EXTENDED SELECT * FROM (
-SELECT a, b, sum(s)
Review comment:
Fine, I will keep the existing test as it is, and thanks a lot for the
review!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 460079)
Time Spent: 40m (was: 0.5h)
> Allow PPD when subject is not a column with grouping sets present
> -----------------------------------------------------------------
>
> Key: HIVE-23850
> URL: https://issues.apache.org/jira/browse/HIVE-23850
> Project: Hive
> Issue Type: Bug
> Components: Logical Optimizer
> Reporter: Zhihua Deng
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> After [HIVE-19653|https://issues.apache.org/jira/browse/HIVE-19653], filters
> with only columns and constants are pushed down, but in some cases, this may
> not work as well, for example:
> SET hive.cbo.enable=false;
> SELECT a, b, sum(s)
> FROM T1
> GROUP BY a, b GROUPING SETS ((a), (a, b))
> HAVING upper(a) = "AAA" AND sum(s) > 100;
>
> SELECT upper(a), b, sum(s)
> FROM T1
> GROUP BY upper(a), b GROUPING SETS ((upper(a)), (upper(a), b))
> HAVING upper(a) = "AAA" AND sum(s) > 100;
>
> The filters pushed down to GBY can be f(gbyKey) or gbyKey with udf , not
> only the column groupby keys.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
