[
https://issues.apache.org/jira/browse/HIVE-23560?focusedWorklogId=459630&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-459630
]
ASF GitHub Bot logged work on HIVE-23560:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jul/20 03:40
Start Date: 16/Jul/20 03:40
Worklog Time Spent: 10m
Work Description: pkumarsinha commented on a change in pull request #1232:
URL: https://github.com/apache/hive/pull/1232#discussion_r455491023
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java
##########
@@ -986,7 +1019,8 @@ String getValidTxnListForReplDump(Hive hiveDb, long
waitUntilTime) throws HiveEx
// phase won't be able to replicate those txns. So, the logic is to wait
for the given amount
// of time to see if all open txns < current txn is getting
aborted/committed. If not, then
// we forcefully abort those txns just like AcidHouseKeeperService.
- ValidTxnList validTxnList = getTxnMgr().getValidTxns();
+ //Exclude readonly and repl created tranasactions
+ ValidTxnList validTxnList =
getTxnMgr().getValidTxns(Arrays.asList(TxnType.READ_ONLY,
TxnType.REPL_CREATED));
Review comment:
Sorry, this comment was for Line number:1036. And I am referring to the
list of excludes: Arrays.asList(TxnType.READ_ONLY, TxnType.REPL_CREATED)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 459630)
Time Spent: 1h 20m (was: 1h 10m)
> Optimize bootstrap dump to abort only write Transactions
> --------------------------------------------------------
>
> Key: HIVE-23560
> URL: https://issues.apache.org/jira/browse/HIVE-23560
> Project: Hive
> Issue Type: Task
> Reporter: Aasha Medhi
> Assignee: Aasha Medhi
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-23560.01.patch, HIVE-23560.02.patch, Optimize
> bootstrap dump to avoid aborting all transactions.pdf
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Currently before doing a bootstrap dump, we abort all open transactions after
> waiting for a configured time. We are proposing to abort only write
> transactions for the db under replication and leave the read and repl created
> transactions as is.
> This doc attached talks about it in detail
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
