[
https://issues.apache.org/jira/browse/HIVE-23814?focusedWorklogId=457915&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-457915
]
ASF GitHub Bot logged work on HIVE-23814:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jul/20 08:57
Start Date: 13/Jul/20 08:57
Worklog Time Spent: 10m
Work Description: pvary commented on a change in pull request #1222:
URL: https://github.com/apache/hive/pull/1222#discussion_r453498040
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/Driver.java
##########
@@ -155,9 +157,11 @@ public int compile(String command, boolean resetTaskIds) {
}
}
- // deferClose indicates if the close/destroy should be deferred when the
process has been
- // interrupted, it should be set to true if the compile is called within
another method like
- // runInternal, which defers the close to the called in that method.
+ /**
+ * @deferClose indicates if the close/destroy should be deferred when the
process has been interrupted, it should be
Review comment:
Maybe a correct javadoc comment? The meaning and the usage of
resetTaskIds is not trivial either
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 457915)
Time Spent: 2.5h (was: 2h 20m)
> Clean up Driver
> ---------------
>
> Key: HIVE-23814
> URL: https://issues.apache.org/jira/browse/HIVE-23814
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Driver is now cut down to it's minimal size by extracting all of it's sub
> tasks to separate classes. The rest should be cleaned up by
> * moving out some smaller parts of the code to sub task and utility classes
> wherever it is still possible
> * fix checkstyle issues
> * add missing javadoc
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
