[
https://issues.apache.org/jira/browse/HIVE-23069?focusedWorklogId=457124&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-457124
]
ASF GitHub Bot logged work on HIVE-23069:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jul/20 12:28
Start Date: 10/Jul/20 12:28
Worklog Time Spent: 10m
Work Description: pkumarsinha commented on a change in pull request #1225:
URL: https://github.com/apache/hive/pull/1225#discussion_r452811664
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java
##########
@@ -591,14 +590,25 @@ private Long incrementalDump(Path dumpRoot, DumpMetaData
dmd, Path cmRoot, Hive
}
}
dumpTableListToDumpLocation(tableList, dumpRoot, dbName, conf);
- extTableCopyWorks = dirLocationsToCopy(extTableLocations);
}
- work.setDirCopyIterator(extTableCopyWorks.iterator());
- work.setManagedTableCopyPathIterator(managedTableCopyPaths.iterator());
+ setDataCopyIterators(extTableFileList, managedTblList);
work.getMetricCollector().reportStageEnd(getName(), Status.SUCCESS,
lastReplId);
return lastReplId;
}
+ private void setDataCopyIterators(FileList extTableFileList, FileList
managedTableFileList) throws IOException {
+ boolean dataCopyAtLoad =
conf.getBoolVar(HiveConf.ConfVars.REPL_DATA_COPY_LAZY);
+ extTableFileList.close();
Review comment:
Close make sure that every thing is flushed out and the list can be used
in READ mode
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 457124)
Time Spent: 1h 20m (was: 1h 10m)
> Memory efficient iterator should be used during replication.
> ------------------------------------------------------------
>
> Key: HIVE-23069
> URL: https://issues.apache.org/jira/browse/HIVE-23069
> Project: Hive
> Issue Type: Improvement
> Reporter: Pravin Sinha
> Assignee: Pravin Sinha
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-23069.01.patch
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Currently the iterator used while copying table data is memory based. In case
> of a database with very large number of table/partitions, such iterator may
> cause HS2 process to go OOM.
> Also introduces a config option to run data copy tasks during repl load
> operation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
