[
https://issues.apache.org/jira/browse/HIVE-23638?focusedWorklogId=456600&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-456600
]
ASF GitHub Bot logged work on HIVE-23638:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jul/20 13:05
Start Date: 09/Jul/20 13:05
Worklog Time Spent: 10m
Work Description: pgaref commented on a change in pull request #1161:
URL: https://github.com/apache/hive/pull/1161#discussion_r452200559
##########
File path: common/src/java/org/apache/hadoop/hive/common/jsonexplain/Vertex.java
##########
@@ -308,6 +309,16 @@ public void setType(String type) {
this.edgeType = this.parser.mapEdgeType(type);
}
+ @Override
+ public boolean equals(Object o) {
+ return super.equals(o);
Review comment:
You are right comparison could be implemented as part of the class
(added that part).
Regarding the parser I agree it should not be a field, only given as
parameter where needed -- there are more places where we follow this weird
implementation and should probably be addressed all together:
https://github.com/apache/hive/blob/ba0217ff17501fb849d8999e808d37579db7b4f1/common/src/java/org/apache/hadoop/hive/common/jsonexplain/Stage.java#L52
and
https://github.com/apache/hive/blob/99f21bb42d7c1b258f5c34b86e71777978e31919/common/src/java/org/apache/hadoop/hive/common/jsonexplain/Op.java#L58
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 456600)
Time Spent: 2h 20m (was: 2h 10m)
> Fix FindBug issues in hive-common
> ---------------------------------
>
> Key: HIVE-23638
> URL: https://issues.apache.org/jira/browse/HIVE-23638
> Project: Hive
> Issue Type: Sub-task
> Reporter: Panagiotis Garefalakis
> Assignee: Panagiotis Garefalakis
> Priority: Major
> Labels: pull-request-available
> Attachments: spotbugsXml.xml
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> mvn -Pspotbugs
> -Dorg.slf4j.simpleLogger.log.org.apache.maven.plugin.surefire.SurefirePlugin=INFO
> -pl :hive-common test-compile
> com.github.spotbugs:spotbugs-maven-plugin:4.0.0:check
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
