[
https://issues.apache.org/jira/browse/HIVE-23800?focusedWorklogId=455287&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-455287
]
ASF GitHub Bot logged work on HIVE-23800:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jul/20 08:13
Start Date: 07/Jul/20 08:13
Worklog Time Spent: 10m
Work Description: dengzhhu653 edited a comment on pull request #1205:
URL: https://github.com/apache/hive/pull/1205#issuecomment-654678113
> I don't see the need for this....what's wrong with
[afterexecute](https://github.com/apache/hive/blob/e4256fc91fe2c123428400f3737883a83208d29e/ql/src/java/org/apache/hadoop/hive/ql/Executor.java#L533)
or
[failurehooks](https://github.com/apache/hive/blob/e4256fc91fe2c123428400f3737883a83208d29e/ql/src/java/org/apache/hadoop/hive/ql/Executor.java#L521)?
> do you have a use case which could not be handled by those?
The oom hook holds a hiveserver2 instance, which calls hiveserver2::stop()
to end hiveserver2 gracefully, which would cleanup the session
directory/scratch(staging) directory/operation log and so on . Although the
hooks in the driver can handle oom, he may not be able to stop the hiveserver2
gracefully as the oom hook does. Sometimes we may want to dump the heap for
futher analysis when oom happens or alter the devops, so it may be better to
make the oom hook here an interface.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 455287)
Time Spent: 0.5h (was: 20m)
> Make HiveServer2 oom hook interface
> -----------------------------------
>
> Key: HIVE-23800
> URL: https://issues.apache.org/jira/browse/HIVE-23800
> Project: Hive
> Issue Type: Improvement
> Components: HiveServer2
> Reporter: Zhihua Deng
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
