[
https://issues.apache.org/jira/browse/HIVE-23467?focusedWorklogId=447523&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-447523
]
ASF GitHub Bot logged work on HIVE-23467:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Jun/20 20:52
Start Date: 17/Jun/20 20:52
Worklog Time Spent: 10m
Work Description: sam-an-cloudera commented on a change in pull request
#1133:
URL: https://github.com/apache/hive/pull/1133#discussion_r441826009
##########
File path:
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java
##########
@@ -105,6 +105,7 @@ protected DateFormat initialValue() {
public static final String DB_EMPTY_MARKER = "!";
public static final String EXTERNAL_TABLE_PURGE = "external.table.purge";
+ public static final String EXTERNAL_TABLE_AUTODELETE =
"external.table.autodelete";
Review comment:
After discussion with @nrg4878 and @thejasmn , we thought it's best that
we don't add this new option because "external.table.purge" is widely used.
Introducing the new autodelete might cause confusion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 447523)
Time Spent: 0.5h (was: 20m)
> Add a skip.trash config for HMS to skip trash when deleting external table
> data
> -------------------------------------------------------------------------------
>
> Key: HIVE-23467
> URL: https://issues.apache.org/jira/browse/HIVE-23467
> Project: Hive
> Issue Type: Improvement
> Components: Hive
> Reporter: Sam An
> Assignee: Yu-Wen Lai
> Priority: Trivial
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> We have an auto.purge flag, which means skip trash. It can be confusing as we
> have 'external.table.purge'='true' to indicate delete table data when this
> tblproperties is set.
> We should make the meaning clearer by introducing a skip trash alias/option.
> Additionally, we shall add an alias for external.table.purge, and name it
> external.table.autodelete, and document it more prominently, so as to
> maintain backward compatibility, and make the meaning of auto deletion of
> data more obvious.
> The net effect of these 2 changes will be. If the user sets
> 'external.table.autodelete'='true'
> the table data will be removed when table is dropped. and if
> 'skip.trash'='true'
> is set, HMS will not move the table data to trash folder when removing the
> files. This will result in faster removal, especially when underlying FS is
> S3.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
