[
https://issues.apache.org/jira/browse/HIVE-23706?focusedWorklogId=447210&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-447210
]
ASF GitHub Bot logged work on HIVE-23706:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Jun/20 10:37
Start Date: 17/Jun/20 10:37
Worklog Time Spent: 10m
Work Description: zabetak commented on a change in pull request #1131:
URL: https://github.com/apache/hive/pull/1131#discussion_r441439599
##########
File path: ql/src/test/results/clientpositive/llap/order_null.q.out
##########
@@ -116,12 +116,12 @@ POSTHOOK: query: SELECT x.* FROM src_null_n1 x ORDER BY b
desc, a asc
POSTHOOK: type: QUERY
POSTHOOK: Input: default@src_null_n1
#### A masked pattern was here ####
-2 B
-1 A
-2 A
2 NULL
3 NULL
NULL NULL
+2 B
+1 A
+2 A
Review comment:
The result that I would expect is:
```
2 B
1 A
2 A
NULL NULL
2 NULL
3 NULL
```
##########
File path: ql/src/test/results/clientpositive/llap/order_null.q.out
##########
@@ -187,9 +187,9 @@ POSTHOOK: type: QUERY
POSTHOOK: Input: default@src_null_n1
#### A masked pattern was here ####
1 A
+2 NULL
2 B
2 A
-2 NULL
3 NULL
NULL NULL
Review comment:
I think that the old result was correct.
##########
File path: ql/src/test/results/clientpositive/llap/order_null.q.out
##########
@@ -88,12 +88,12 @@ POSTHOOK: query: SELECT x.* FROM src_null_n1 x ORDER BY a
desc
POSTHOOK: type: QUERY
POSTHOOK: Input: default@src_null_n1
#### A masked pattern was here ####
+NULL NULL
3 NULL
2 NULL
2 A
2 B
1 A
-NULL NULL
Review comment:
I think that the old result was correct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 447210)
Time Spent: 20m (was: 10m)
> Fix nulls first sorting behavior
> --------------------------------
>
> Key: HIVE-23706
> URL: https://issues.apache.org/jira/browse/HIVE-23706
> Project: Hive
> Issue Type: Bug
> Components: Parser
> Reporter: Krisztian Kasa
> Assignee: Krisztian Kasa
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {code}
> INSERT INTO t(a) VALUES (1, null, 3, 2, 2, 2)
> SELECT a FROM t ORDER BY a DESC NULLS FIRST
> {code}
> should return
> {code}
> 3
> 2
> 2
> 2
> 1
> null
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
