[
https://issues.apache.org/jira/browse/HIVE-23683?focusedWorklogId=445974&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-445974
]
ASF GitHub Bot logged work on HIVE-23683:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jun/20 17:55
Start Date: 15/Jun/20 17:55
Worklog Time Spent: 10m
Work Description: klcopp commented on a change in pull request #1101:
URL: https://github.com/apache/hive/pull/1101#discussion_r440343846
##########
File path: ql/src/test/queries/clientpositive/dbtxnmgr_showlocks.q
##########
@@ -1,3 +1,4 @@
+ --! qt:replace:/(initiated\s+---\s+---\s+)[0-9]*(\s+---)/$1#Masked#$2/
Review comment:
Nit: maybe add a comment here about what's going on, to save someone
time down the road
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/ddl/process/show/compactions/ShowCompactionsOperation.java
##########
@@ -81,6 +81,8 @@ private void writeHeader(DataOutputStream os) throws
IOException {
os.write(Utilities.tabCode);
os.writeBytes("Worker");
os.write(Utilities.tabCode);
+ os.writeBytes("Queue Time");
Review comment:
"Queue time" sounds like "time spent in queue." Something like "Entered
queue" sounds more like a timestamp to me.
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionInfo.java
##########
@@ -116,6 +117,7 @@ public String toString() {
"partName:" + partName + "," +
"state:" + state + "," +
"type:" + type + "," +
+ "queueTime:" + queueTime + "," +
Review comment:
(Opportunity: "start" is missing from this method)
##########
File path: ql/src/test/queries/clientpositive/sysdb.q
##########
@@ -1,5 +1,6 @@
--! qt:dataset:src,part,srcbucket:ONLY
--! qt:sysdb
+--! qt:replace:/(initiated\s+NULL\s+NULL\s+)[0-9]*(\s+NULL)/$1#Masked#$2/
Review comment:
Nit: maybe add a comment here about what's going on, to save someone
time down the road
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 445974)
Time Spent: 20m (was: 10m)
> Add queue time to compaction
> ----------------------------
>
> Key: HIVE-23683
> URL: https://issues.apache.org/jira/browse/HIVE-23683
> Project: Hive
> Issue Type: Improvement
> Components: Transactions
> Reporter: Peter Vary
> Assignee: Peter Vary
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> It would be good to report to the user when the transaction is initiated.
> This info can be used when considering the health status of the compaction
> system
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
