[ 
https://issues.apache.org/jira/browse/HIVE-23556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130777#comment-17130777
 ] 

Toshihiko Uchida commented on HIVE-23556:
-----------------------------------------

[~kgyrtkirk] Thanks for your comment!
The Deprecated annotation for get_partitions_ps_with_auth has been added in 
HIVE-22017 very recently, and it is still called from the corresponding new API.
{code}
    @Override
    public GetPartitionsPsWithAuthResponse 
get_partitions_ps_with_auth_req(GetPartitionsPsWithAuthRequest req)
            throws MetaException, NoSuchObjectException, TException {
      String dbName = MetaStoreUtils.prependCatalogToDbName(req.getCatName(), 
req.getDbName(), conf);
      List<Partition> partitions = get_partitions_ps_with_auth(dbName, 
req.getTblName(),
              req.getPartVals(), req.getMaxParts(), req.getUserName(), 
req.getGroupNames());
      GetPartitionsPsWithAuthResponse res = new 
GetPartitionsPsWithAuthResponse();
      res.setPartitions(partitions);
      return res;
    }
{code}
The same change has been applied to other APIs such as get_partitions as well.

About the usage, I'm not sure what you mean by "indirectly", but currently 
Spark calls it from Hive#getPartitions when no partition filter is provided.
https://github.com/apache/spark/blob/3a48ea1/sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala#L736
Actually, this is why I noticed the issue.

> Support hive.metastore.limit.partition.request for get_partitions_ps
> --------------------------------------------------------------------
>
>                 Key: HIVE-23556
>                 URL: https://issues.apache.org/jira/browse/HIVE-23556
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Toshihiko Uchida
>            Assignee: Toshihiko Uchida
>            Priority: Minor
>         Attachments: HIVE-23556.2.patch, HIVE-23556.3.patch, 
> HIVE-23556.4.patch, HIVE-23556.patch
>
>
> HIVE-13884 added the configuration hive.metastore.limit.partition.request to 
> limit the number of partitions that can be requested.
> Currently, it takes in effect for the following MetaStore APIs
> * get_partitions,
> * get_partitions_with_auth,
> * get_partitions_by_filter,
> * get_partitions_spec_by_filter,
> * get_partitions_by_expr,
> but not for
> * get_partitions_ps,
> * get_partitions_ps_with_auth.
> This issue proposes to apply the configuration also to get_partitions_ps and 
> get_partitions_ps_with_auth.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to