[
https://issues.apache.org/jira/browse/HIVE-23627?focusedWorklogId=443720&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-443720
]
ASF GitHub Bot logged work on HIVE-23627:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jun/20 13:25
Start Date: 10/Jun/20 13:25
Worklog Time Spent: 10m
Work Description: belugabehr commented on a change in pull request #1067:
URL: https://github.com/apache/hive/pull/1067#discussion_r438119291
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java
##########
@@ -90,13 +91,11 @@
// so aggregationIsDistinct is a boolean array instead of a single number.
private transient boolean[] aggregationIsDistinct;
// Map from integer tag to distinct aggrs
- private transient Map<Integer, Set<Integer>> distinctKeyAggrs =
- new HashMap<Integer, Set<Integer>>();
+ private transient Map<Integer, Set<Integer>> distinctKeyAggrs = new
HashMap<>();
// Map from integer tag to non-distinct aggrs with key parameters.
- private transient Map<Integer, Set<Integer>> nonDistinctKeyAggrs =
- new HashMap<Integer, Set<Integer>>();
+ private transient Map<Integer, Set<Integer>> nonDistinctKeyAggrs = new
HashMap<>();
// List of non-distinct aggrs.
- private transient List<Integer> nonDistinctAggrs = new ArrayList<Integer>();
+ private transient Set<Integer> nonDistinctAggrs = new LinkedHashSet<>();
Review comment:
@zabetak Yes. You are 100% correct about your assumptions about my
motivations. Bravo.
I will change to `HashSet` and let anyone else take a crack at more
refactoring.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 443720)
Time Spent: 1h 40m (was: 1.5h)
> Review of GroupByOperator
> -------------------------
>
> Key: HIVE-23627
> URL: https://issues.apache.org/jira/browse/HIVE-23627
> Project: Hive
> Issue Type: Improvement
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
