[
https://issues.apache.org/jira/browse/HIVE-23516?focusedWorklogId=442213&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-442213
]
ASF GitHub Bot logged work on HIVE-23516:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jun/20 09:06
Start Date: 06/Jun/20 09:06
Worklog Time Spent: 10m
Work Description: pkumarsinha commented on a change in pull request #1044:
URL: https://github.com/apache/hive/pull/1044#discussion_r436252777
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/metric/MetricCollector.java
##########
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.ql.parse.repl.metric;
+
+import org.apache.hadoop.hive.conf.HiveConf;
+import org.apache.hadoop.hive.metastore.conf.MetastoreConf;
+import org.apache.hadoop.hive.ql.parse.SemanticException;
+import org.apache.hadoop.hive.ql.parse.repl.metric.event.ReplicationMetric;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+
+/**
+ * MetricCollector.
+ * In memory collection of metrics
+ */
+public final class MetricCollector {
+ private static final Logger LOG =
LoggerFactory.getLogger(MetricCollector.class);
+ private Map<Long, ReplicationMetric> metricMap = new ConcurrentHashMap<>();
Review comment:
When you already have it synchronized, you don't need it. Unnecessarily
it will try acquiring monitor on Map object which no other thread holds. When
additional api comes here and if it interacts with this Map object, any way we
will end up making that method synchronized so we won't need it.
Also, we should mark this object as final.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 442213)
Time Spent: 5h 20m (was: 5h 10m)
> Store hive replication policy execution metrics in the relational DB
> --------------------------------------------------------------------
>
> Key: HIVE-23516
> URL: https://issues.apache.org/jira/browse/HIVE-23516
> Project: Hive
> Issue Type: Task
> Reporter: Aasha Medhi
> Assignee: Aasha Medhi
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-23516.01.patch, HIVE-23516.02.patch,
> HIVE-23516.03.patch, HIVE-23516.04.patch, HIVE-23516.05.patch,
> HIVE-23516.06.patch, HIVE-23516.07.patch, HIVE-23516.08.patch,
> HIVE-23516.09.patch, HIVE-23516.10.patch, HIVE-23516.11.patch,
> HIVE-23516.12.patch, HIVE-23516.13.patch, HIVE-23516.14.patch,
> HIVE-23516.15.patch, Replication Metrics.pdf
>
> Time Spent: 5h 20m
> Remaining Estimate: 0h
>
> Details documented in the attached doc
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
