[
https://issues.apache.org/jira/browse/HIVE-23617?focusedWorklogId=442003&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-442003
]
ASF GitHub Bot logged work on HIVE-23617:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Jun/20 19:22
Start Date: 05/Jun/20 19:22
Worklog Time Spent: 10m
Work Description: belugabehr commented on a change in pull request #1063:
URL: https://github.com/apache/hive/pull/1063#discussion_r436118081
##########
File path:
storage-api/src/java/org/apache/hadoop/hive/common/io/encoded/EncodedColumnBatch.java
##########
@@ -78,13 +78,13 @@ public void setIndexBaseOffset(int indexBaseOffset) {
@Override
public String toString() {
- String bufStr = "";
+ StringBuffer bufStr = new StringBuffer();
if (cacheBuffers != null) {
for (MemoryBuffer mb : cacheBuffers) {
- bufStr += mb.getClass().getSimpleName() + " with " +
mb.getByteBufferRaw().remaining() + " bytes, ";
+ bufStr.append(mb.getClass().getSimpleName() + " with " +
mb.getByteBufferRaw().remaining() + " bytes, ");
Review comment:
I think it's a little bit more than this. There shouldn't be any "+"
concatenation. Should all be `.append()`
I already proposed to addressed this issue (HIVE-23540), but happy to defer
to this PR
https://issues.apache.org/jira/browse/HIVE-23540
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 442003)
Time Spent: 1h (was: 50m)
> Fix FindBug issues in storage-api
> ---------------------------------
>
> Key: HIVE-23617
> URL: https://issues.apache.org/jira/browse/HIVE-23617
> Project: Hive
> Issue Type: Sub-task
> Components: storage-api
> Reporter: Panagiotis Garefalakis
> Assignee: Panagiotis Garefalakis
> Priority: Major
> Labels: pull-request-available
> Attachments: findbugsXml.xml
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> {code:java}
> mvn -DskipTests test-compile findbugs:findbugs -DskipTests=true -pl
> storage-api
> {code}
> {code:java}
> mvn findbugs:gui
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
