[
https://issues.apache.org/jira/browse/HIVE-23516?focusedWorklogId=440373&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440373
]
ASF GitHub Bot logged work on HIVE-23516:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Jun/20 18:17
Start Date: 02/Jun/20 18:17
Worklog Time Spent: 10m
Work Description: pkumarsinha commented on a change in pull request #1044:
URL: https://github.com/apache/hive/pull/1044#discussion_r434083659
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/metric/MetricCollector.java
##########
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.ql.parse.repl.metric;
+
+import org.apache.hadoop.hive.ql.parse.SemanticException;
+import org.apache.hadoop.hive.ql.parse.repl.metric.event.ReplicationMetric;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+
+/**
+ * MetricCollector.
+ * In memory collection of metrics
+ */
+public class MetricCollector {
+ private Logger LOG = LoggerFactory.getLogger(MetricCollector.class);
+ private Map<Long, ReplicationMetric> metricMap = new ConcurrentHashMap<>();
+ private final long maxSize;
+
+ private static volatile MetricCollector instance;
+
+ private MetricCollector(long maxSize){
+ this.maxSize = maxSize;
+ }
+
+ public static MetricCollector getInstance(long maxSize) {
+ if (instance == null) {
+ synchronized (MetricCollector.class) {
+ if (instance == null) {
+ instance = new MetricCollector(maxSize);
+ }
+ }
+ }
+ return instance;
+ }
+
+ public void addMetric(ReplicationMetric replicationMetric) throws
SemanticException {
+ if (metricMap.size() > maxSize) {
+ throw new SemanticException("Metrics are not getting collected. ");
+ } else {
+ if (metricMap.size() > 0.8 * maxSize) { //soft limit
Review comment:
It will keep on printing this for every entry from 80%-100% with same
message. Which will not help know if it at stuck at 80 or is >80 but <100. Can
we have real percentage printed there.
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/metric/MetricCollector.java
##########
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.ql.parse.repl.metric;
+
+import org.apache.hadoop.hive.ql.parse.SemanticException;
+import org.apache.hadoop.hive.ql.parse.repl.metric.event.ReplicationMetric;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+
+/**
+ * MetricCollector.
+ * In memory collection of metrics
+ */
+public class MetricCollector {
+ private Logger LOG = LoggerFactory.getLogger(MetricCollector.class);
+ private Map<Long, ReplicationMetric> metricMap = new ConcurrentHashMap<>();
+ private final long maxSize;
+
+ private static volatile MetricCollector instance;
+
+ private MetricCollector(long maxSize){
+ this.maxSize = maxSize;
+ }
+
+ public static MetricCollector getInstance(long maxSize) {
+ if (instance == null) {
+ synchronized (MetricCollector.class) {
+ if (instance == null) {
+ instance = new MetricCollector(maxSize);
+ }
+ }
+ }
+ return instance;
+ }
+
+ public void addMetric(ReplicationMetric replicationMetric) throws
SemanticException {
+ if (metricMap.size() > maxSize) {
+ throw new SemanticException("Metrics are not getting collected. ");
+ } else {
+ if (metricMap.size() > 0.8 * maxSize) { //soft limit
+ LOG.error("Metrics cache is 80 % full. Will start dropping metrics
once full. ");
Review comment:
It's not an error condition at 80%. We can use warn in stead.
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/metric/MetricCollector.java
##########
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.ql.parse.repl.metric;
+
+import org.apache.hadoop.hive.ql.parse.SemanticException;
+import org.apache.hadoop.hive.ql.parse.repl.metric.event.ReplicationMetric;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+
+/**
+ * MetricCollector.
+ * In memory collection of metrics
+ */
+public class MetricCollector {
+ private Logger LOG = LoggerFactory.getLogger(MetricCollector.class);
+ private Map<Long, ReplicationMetric> metricMap = new ConcurrentHashMap<>();
+ private final long maxSize;
+
+ private static volatile MetricCollector instance;
+
+ private MetricCollector(long maxSize){
+ this.maxSize = maxSize;
+ }
+
+ public static MetricCollector getInstance(long maxSize) {
Review comment:
when it is first time you call this method with getInstance(10) it gets
initialized with 10. On subsequent calls caller calls getInstance(20),
getInstance(100) etc, but it will get the same instance. This will mislead the
caller.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 440373)
Time Spent: 3h 10m (was: 3h)
> Store hive replication policy execution metrics in the relational DB
> --------------------------------------------------------------------
>
> Key: HIVE-23516
> URL: https://issues.apache.org/jira/browse/HIVE-23516
> Project: Hive
> Issue Type: Task
> Reporter: Aasha Medhi
> Assignee: Aasha Medhi
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-23516.01.patch, HIVE-23516.02.patch, Replication
> Metrics.pdf
>
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> Details documented in the attached doc
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
