[ https://issues.apache.org/jira/browse/HIVE-23466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17114466#comment-17114466 ]
Hive QA commented on HIVE-23466: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/13003331/HIVE-23466.1.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/22556/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/22556/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-22556/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Tests exited with: NonZeroExitCodeException Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ date '+%Y-%m-%d %T.%3N' 2020-05-23 01:15:57.414 + [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]] + export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'MAVEN_OPTS=-Xmx1g ' + MAVEN_OPTS='-Xmx1g ' + cd /data/hiveptest/working/ + tee /data/hiveptest/logs/PreCommit-HIVE-Build-22556/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ git = \s\v\n ]] + [[ git = \g\i\t ]] + [[ -z master ]] + [[ -d apache-github-source-source ]] + [[ ! -d apache-github-source-source/.git ]] + [[ ! -d apache-github-source-source ]] + date '+%Y-%m-%d %T.%3N' 2020-05-23 01:15:57.419 + cd apache-github-source-source + git fetch origin >From https://github.com/apache/hive e649562..c641497 master -> origin/master + git reset --hard HEAD HEAD is now at e649562 HIVE-22066: Upgrade Apache parent POM to version 21 (David Mollitor, reviewed by Ashutosh Chauhan) + git clean -f -d Removing standalone-metastore/metastore-server/src/gen/ + git checkout master Already on 'master' Your branch is behind 'origin/master' by 1 commit, and can be fast-forwarded. (use "git pull" to update your local branch) + git reset --hard origin/master HEAD is now at c641497 HIVE-23513 Fix Json output for SHOW TABLES and SHOW MATERIALIZED VIEWS (Miklos Gergely, reviewed by Zoltan Haindrich) + git merge --ff-only origin/master Already up-to-date. + date '+%Y-%m-%d %T.%3N' 2020-05-23 01:15:58.860 + rm -rf ../yetus_PreCommit-HIVE-Build-22556 + mkdir ../yetus_PreCommit-HIVE-Build-22556 + git gc + cp -R . ../yetus_PreCommit-HIVE-Build-22556 + mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-22556/yetus + patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hiveptest/working/scratch/build.patch + [[ -f /data/hiveptest/working/scratch/build.patch ]] + chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh + /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch Trying to apply the patch with -p0 error: a/llap-client/src/java/org/apache/hadoop/hive/registry/impl/ZkRegistryBase.java: does not exist in index error: a/llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/ContainerFactory.java: does not exist in index error: a/llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java: does not exist in index Trying to apply the patch with -p1 error: patch failed: llap-client/src/java/org/apache/hadoop/hive/registry/impl/ZkRegistryBase.java:448 error: repository lacks the necessary blob to fall back on 3-way merge. error: llap-client/src/java/org/apache/hadoop/hive/registry/impl/ZkRegistryBase.java: patch does not apply Trying to apply the patch with -p2 error: src/java/org/apache/hadoop/hive/registry/impl/ZkRegistryBase.java: does not exist in index error: src/java/org/apache/hadoop/hive/llap/tezplugins/ContainerFactory.java: does not exist in index error: src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java: does not exist in index The patch does not appear to apply with p0, p1, or p2 + result=1 + '[' 1 -ne 0 ']' + rm -rf yetus_PreCommit-HIVE-Build-22556 + exit 1 ' {noformat} This message is automatically generated. ATTACHMENT ID: 13003331 - PreCommit-HIVE-Build > ZK registry base should remove only specific instance instead of host > --------------------------------------------------------------------- > > Key: HIVE-23466 > URL: https://issues.apache.org/jira/browse/HIVE-23466 > Project: Hive > Issue Type: Bug > Affects Versions: 4.0.0 > Reporter: Prasanth Jayachandran > Assignee: Attila Magyar > Priority: Major > Attachments: HIVE-23466.1.patch > > > When ZKRegistryBase detects new ZK nodes it maintains path based cache and > host based cache. The host based cached already handles multiple instances > running in same host. But even if single instance is removed all instances > belonging to the host are removed. > Another issue is that, if single host has multiple instances it returns a Set > with no ordering. Ideally, we want the newest instance to be top of the set > (use TreeSet maybe?). -- This message was sent by Atlassian Jira (v8.3.4#803005)