[
https://issues.apache.org/jira/browse/HIVE-23281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113877#comment-17113877
]
Hive QA commented on HIVE-23281:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13003697/HIVE-23281.7.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 51 failed/errored test(s), 17281 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[acid_bucket_pruning]
(batchId=22)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[mm_all]
(batchId=27)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[acid_no_buckets]
(batchId=101)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[acid_nullscan]
(batchId=99)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[acid_stats2]
(batchId=79)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[acid_stats5]
(batchId=51)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[acid_table_directories_test]
(batchId=66)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[acid_table_stats]
(batchId=85)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[autoColumnStats_4]
(batchId=43)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[check_constraint]
(batchId=49)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[create_or_replace_view]
(batchId=71)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[create_transactional_full_acid]
(batchId=108)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[create_transactional_insert_only]
(batchId=91)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[create_view_partitioned]
(batchId=69)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[default_constraint]
(batchId=70)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[describe_formatted_view_partitioned]
(batchId=110)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[describe_formatted_view_partitioned_json]
(batchId=88)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[insert_values_orig_table_use_metadata]
(batchId=96)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[mm_bhif]
(batchId=45)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[mm_default]
(batchId=117)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[mm_exim]
(batchId=124)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[murmur_hash_migration2]
(batchId=79)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sqlmerge_stats]
(batchId=110)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[stats_nonpart]
(batchId=43)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[stats_part2]
(batchId=51)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[stats_part]
(batchId=80)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[stats_sizebug]
(batchId=114)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[alter_view_as_select_with_partition]
(batchId=8)
org.apache.hadoop.hive.metastore.TestEmbeddedHiveMetaStore.testAlterViewParititon
(batchId=158)
org.apache.hadoop.hive.metastore.TestRemoteHiveMetaStore.testAlterViewParititon
(batchId=160)
org.apache.hadoop.hive.metastore.TestRemoteHiveMetaStoreCustomAuth.testAlterViewParititon
(batchId=166)
org.apache.hadoop.hive.metastore.TestRemoteHiveMetaStoreZK.testAlterViewParititon
(batchId=159)
org.apache.hadoop.hive.metastore.TestRemoteHiveMetaStoreZKBindHost.testAlterViewParititon
(batchId=166)
org.apache.hadoop.hive.metastore.TestSetUGIOnBothClientServer.testAlterViewParititon
(batchId=156)
org.apache.hadoop.hive.metastore.TestSetUGIOnOnlyClient.testAlterViewParititon
(batchId=154)
org.apache.hadoop.hive.metastore.TestSetUGIOnOnlyServer.testAlterViewParititon
(batchId=165)
org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionsForViewNullPartSd[Embedded]
(batchId=155)
org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionsForViewNullPartSd[Remote]
(batchId=155)
org.apache.hadoop.hive.metastore.client.TestAddPartitionsFromPartSpec.testAddPartitionsForViewNullPartSd[Embedded]
(batchId=157)
org.apache.hadoop.hive.metastore.client.TestAddPartitionsFromPartSpec.testAddPartitionsForViewNullPartSd[Remote]
(batchId=157)
org.apache.hadoop.hive.ql.TestTxnExIm.testImport (batchId=278)
org.apache.hadoop.hive.ql.TestTxnExIm.testImportPartitioned (batchId=278)
org.apache.hadoop.hive.ql.TestTxnExIm.testImportPartitionedCreate (batchId=278)
org.apache.hadoop.hive.ql.TestTxnExIm.testImportPartitionedOrc (batchId=278)
org.apache.hadoop.hive.ql.TestTxnExIm.testImportVectorized (batchId=278)
org.apache.hadoop.hive.ql.TestTxnExIm.testMM (batchId=278)
org.apache.hadoop.hive.ql.TestTxnExIm.testMMFlatSource (batchId=278)
org.apache.hive.hcatalog.api.TestHCatClientNotification.dropTable (batchId=227)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreDualAuthCustom.testAlterViewParititon
(batchId=238)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreDualAuthKerb.testAlterViewParititon
(batchId=238)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testAlterViewParititon
(batchId=238)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/22541/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/22541/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-22541/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 51 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 13003697 - PreCommit-HIVE-Build
> ObjectStore::convertToStorageDescriptor can be optimised to reduce calls to
> DB for ACID tables
> ----------------------------------------------------------------------------------------------
>
> Key: HIVE-23281
> URL: https://issues.apache.org/jira/browse/HIVE-23281
> Project: Hive
> Issue Type: Improvement
> Reporter: Rajesh Balamohan
> Assignee: Ramesh Kumar Thangarajan
> Priority: Major
> Attachments: HIVE-23281.1.patch, HIVE-23281.2.patch,
> HIVE-23281.3.patch, HIVE-23281.4.patch, HIVE-23281.5.patch,
> HIVE-23281.6.patch, HIVE-23281.7.patch, image-2020-04-23-13-56-17-210.png
>
>
> [https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java#L1980]
>
> [https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java#L1982]
>
> SkewInfo, bucketCols, ordering etc are not needed for ACID tables. It may be
> good to check for transactional tables and get rid these calls in table
> lookups.
>
> This should help in reducing DB calls.
> !image-2020-04-23-13-56-17-210.png|width=669,height=485!
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
