[ 
https://issues.apache.org/jira/browse/HIVE-23455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17105927#comment-17105927
 ] 

Hive QA commented on HIVE-23455:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13002768/HIVE-23455.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 17266 tests 
executed
*Failed tests:*
{noformat}
org.apache.hive.service.cli.session.TestSessionManagerMetrics.testAbandonedSessionMetrics
 (batchId=167)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/22299/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/22299/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-22299/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 13002768 - PreCommit-HIVE-Build

> Improve error message for external orc table
> --------------------------------------------
>
>                 Key: HIVE-23455
>                 URL: https://issues.apache.org/jira/browse/HIVE-23455
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Mustafa Iman
>            Assignee: Mustafa Iman
>            Priority: Major
>         Attachments: HIVE-23455.patch, acid_table_as_external.q, 
> acid_table_as_external.q.out
>
>
> Since there is no schema validation for external tables, users may face 
> various errors if their orc data and external table schema does not match. If 
> orc schema has fewer columns than projection OrcEncodedDataConsumer may 
> receive an incomplete TypeDescription array which will manifest itself as 
> NullPointerException later.
> We can at least verify that OrcEncodedDataConsumer gets enough 
> TypeDescriptions. If assertion fails, user sees there is something wrong with 
> the schema and hopefully resolves the problem quickly. If there are enough 
> columns in the file but the schema of the query does not match, user 
> generally sees a ClassCastException. If there are enough columns and types 
> accidentally match, there is nothing we can do as this is an external table.
> We have seen this when trying to use a managed table as external table 
> location. Although user facing schemas are the same, managed table has acid 
> related metadata. I am adding a q file demonstrating NullPointerException 
> with TestMiniLlapLocalCliDriver and the output after the fix. I haven't added 
> this to precommit tests as it is hard to assert the exception message from 
> mini driver framework and effectively it is just changing the error.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to