[ https://issues.apache.org/jira/browse/HIVE-23017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104726#comment-17104726 ]
Hive QA commented on HIVE-23017: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/13002636/HIVE-23017.2.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/22270/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/22270/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-22270/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Tests exited with: NonZeroExitCodeException Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ date '+%Y-%m-%d %T.%3N' 2020-05-11 17:56:34.543 + [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]] + export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'MAVEN_OPTS=-Xmx1g ' + MAVEN_OPTS='-Xmx1g ' + cd /data/hiveptest/working/ + tee /data/hiveptest/logs/PreCommit-HIVE-Build-22270/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ git = \s\v\n ]] + [[ git = \g\i\t ]] + [[ -z master ]] + [[ -d apache-github-source-source ]] + [[ ! -d apache-github-source-source/.git ]] + [[ ! -d apache-github-source-source ]] + date '+%Y-%m-%d %T.%3N' 2020-05-11 17:56:34.546 + cd apache-github-source-source + git fetch origin >From https://github.com/apache/hive 1763c04..204d852 storage-branch-2.7 -> origin/storage-branch-2.7 + git reset --hard HEAD HEAD is now at dac0696 HIVE-23403 Move q tests to TestMiniLlapLocal from TestCliDriver where the output is different, batch 2 (Miklos Gergely, reviewed by Jesus Camacho Rodriguez) + git clean -f -d Removing standalone-metastore/metastore-server/src/gen/ + git checkout master Already on 'master' Your branch is up-to-date with 'origin/master'. + git reset --hard origin/master HEAD is now at dac0696 HIVE-23403 Move q tests to TestMiniLlapLocal from TestCliDriver where the output is different, batch 2 (Miklos Gergely, reviewed by Jesus Camacho Rodriguez) + git merge --ff-only origin/master Already up-to-date. + date '+%Y-%m-%d %T.%3N' 2020-05-11 17:56:36.007 + rm -rf ../yetus_PreCommit-HIVE-Build-22270 + mkdir ../yetus_PreCommit-HIVE-Build-22270 + git gc + cp -R . ../yetus_PreCommit-HIVE-Build-22270 + mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-22270/yetus + patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hiveptest/working/scratch/build.patch + [[ -f /data/hiveptest/working/scratch/build.patch ]] + chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh + /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch Trying to apply the patch with -p0 error: a/ql/src/java/org/apache/hadoop/hive/ql/ddl/DDLTask.java: does not exist in index error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/ColumnStatsUpdateTask.java: does not exist in index error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainSQRewriteTask.java: does not exist in index error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java: does not exist in index error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/ExportTask.java: does not exist in index error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java: does not exist in index error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java: does not exist in index error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/ReplCopyTask.java: does not exist in index error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/ReplTxnTask.java: does not exist in index error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java: does not exist in index error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java: does not exist in index error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java: does not exist in index error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java: does not exist in index error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java: does not exist in index error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/repl/DirCopyTask.java: does not exist in index error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java: does not exist in index error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplLoadTask.java: does not exist in index error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/schq/ScheduledQueryMaintenanceTask.java: does not exist in index error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkTask.java: does not exist in index error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java: does not exist in index error: a/ql/src/java/org/apache/hadoop/hive/ql/io/merge/MergeFileTask.java: does not exist in index error: a/ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/truncate/ColumnTruncateTask.java: does not exist in index error: a/ql/src/test/org/apache/hadoop/hive/ql/exec/TestUtilities.java: does not exist in index Trying to apply the patch with -p1 error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java:56 error: repository lacks the necessary blob to fall back on 3-way merge. error: ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java: patch does not apply error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java:398 error: repository lacks the necessary blob to fall back on 3-way merge. error: ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java: patch does not apply error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkTask.java:98 error: repository lacks the necessary blob to fall back on 3-way merge. error: ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkTask.java: patch does not apply error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java:421 error: repository lacks the necessary blob to fall back on 3-way merge. error: ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java: patch does not apply Trying to apply the patch with -p2 error: src/java/org/apache/hadoop/hive/ql/ddl/DDLTask.java: does not exist in index error: src/java/org/apache/hadoop/hive/ql/exec/ColumnStatsUpdateTask.java: does not exist in index error: src/java/org/apache/hadoop/hive/ql/exec/ExplainSQRewriteTask.java: does not exist in index error: src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java: does not exist in index error: src/java/org/apache/hadoop/hive/ql/exec/ExportTask.java: does not exist in index error: src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java: does not exist in index error: src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java: does not exist in index error: src/java/org/apache/hadoop/hive/ql/exec/ReplCopyTask.java: does not exist in index error: src/java/org/apache/hadoop/hive/ql/exec/ReplTxnTask.java: does not exist in index error: src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java: does not exist in index error: src/java/org/apache/hadoop/hive/ql/exec/Task.java: does not exist in index error: src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java: does not exist in index error: src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java: does not exist in index error: src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java: does not exist in index error: src/java/org/apache/hadoop/hive/ql/exec/repl/DirCopyTask.java: does not exist in index error: src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java: does not exist in index error: src/java/org/apache/hadoop/hive/ql/exec/repl/ReplLoadTask.java: does not exist in index error: src/java/org/apache/hadoop/hive/ql/exec/schq/ScheduledQueryMaintenanceTask.java: does not exist in index error: src/java/org/apache/hadoop/hive/ql/exec/spark/SparkTask.java: does not exist in index error: src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java: does not exist in index error: src/java/org/apache/hadoop/hive/ql/io/merge/MergeFileTask.java: does not exist in index error: src/java/org/apache/hadoop/hive/ql/io/rcfile/truncate/ColumnTruncateTask.java: does not exist in index error: src/test/org/apache/hadoop/hive/ql/exec/TestUtilities.java: does not exist in index The patch does not appear to apply with p0, p1, or p2 + result=1 + '[' 1 -ne 0 ']' + rm -rf yetus_PreCommit-HIVE-Build-22270 + exit 1 ' {noformat} This message is automatically generated. ATTACHMENT ID: 13002636 - PreCommit-HIVE-Build > Use Inherited Logger in Tasks > ----------------------------- > > Key: HIVE-23017 > URL: https://issues.apache.org/jira/browse/HIVE-23017 > Project: Hive > Issue Type: Improvement > Reporter: David Mollitor > Assignee: David Mollitor > Priority: Minor > Attachments: HIVE-23017.1.patch, HIVE-23017.2.patch > > > {code:java|title=FetchTask} > public class FetchTask extends Task<FetchWork> implements Serializable { > private static final long serialVersionUID = 1L; > private int maxRows = 100; > private FetchOperator fetch; > private ListSinkOperator sink; > private int totalRows; > private static transient final Logger LOG = > LoggerFactory.getLogger(FetchTask.class); > JobConf job = null; > {code} > The Tasks class is base class for many other. Cleaner to simply make the > {{Logger}} {{protected}} and usable by other classes. -- This message was sent by Atlassian Jira (v8.3.4#803005)