[
https://issues.apache.org/jira/browse/HIVE-23389?focusedWorklogId=432465&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-432465
]
ASF GitHub Bot logged work on HIVE-23389:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/May/20 01:24
Start Date: 10/May/20 01:24
Worklog Time Spent: 10m
Work Description: jcamachor commented on pull request #1010:
URL: https://github.com/apache/hive/pull/1010#issuecomment-626258279
> I guess you plan to add a test when you commit in Calcite.
Yes, I could not repro the issue in Hive and I do not see any regressions,
hence that should be sufficient. However, I will add a test to Calcite as part
of the commit (assuming I can reproduce the issue over there).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 432465)
Time Spent: 40m (was: 0.5h)
> FilterMergeRule can lead to AssertionError
> ------------------------------------------
>
> Key: HIVE-23389
> URL: https://issues.apache.org/jira/browse/HIVE-23389
> Project: Hive
> Issue Type: Bug
> Components: CBO
> Reporter: Jesus Camacho Rodriguez
> Assignee: Jesus Camacho Rodriguez
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-23389.01.patch, HIVE-23389.01.patch,
> HIVE-23389.02.patch, HIVE-23389.patch
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> I have not been able to reproduce the issue in latest master. However, this
> could potentially happen since Filter creation has a check on whether the
> expression is flat
> ([here|https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/rel/core/Filter.java#L74])
> and Filter merge does not flatten an expression when it is created.
> {noformat}
> java.lang.AssertionError: AND(=($3, 100), OR(OR(null, IS NOT
> NULL(CAST(100):INTEGER)), =(CAST(100):INTEGER, CAST(200):INTEGER)))
> at org.apache.calcite.rel.core.Filter.<init>(Filter.java:74)
> at
> org.apache.hadoop.hive.ql.optimizer.calcite.reloperators.HiveFilter.<init>(HiveFilter.java:39)
> at
> org.apache.hadoop.hive.ql.optimizer.calcite.HiveRelFactories$HiveFilterFactoryImpl.createFilter(HiveRelFactories.java:126)
> at
> org.apache.hadoop.hive.ql.optimizer.calcite.HiveRelBuilder.filter(HiveRelBuilder.java:99)
> at org.apache.calcite.tools.RelBuilder.filter(RelBuilder.java:1055)
> at
> org.apache.calcite.rel.rules.FilterMergeRule.onMatch(FilterMergeRule.java:81)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
