[
https://issues.apache.org/jira/browse/HIVE-23108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097209#comment-17097209
]
Hive QA commented on HIVE-23108:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13001730/HIVE-23108.5.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 17201 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/22049/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/22049/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-22049/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 13001730 - PreCommit-HIVE-Build
> Cleanup HiveBaseResultSet.java
> ------------------------------
>
> Key: HIVE-23108
> URL: https://issues.apache.org/jira/browse/HIVE-23108
> Project: Hive
> Issue Type: Improvement
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Minor
> Attachments: HIVE-23108.1.patch, HIVE-23108.2.patch,
> HIVE-23108.3.patch, HIVE-23108.4.patch, HIVE-23108.5.patch,
> HIVE-23108.5.patch, HIVE-23108.5.patch
>
>
> * Unify the code (there are several implementations of the same thing)
> * Added better error messages
> * In some cases, the code was throwing RuntimeExceptions which is against
> the JDBC Spec
> * Make findColumn a bit more streamlined
> * Remove non-javadoc comments
> * Add {{@Override}} annotations where appropriate
> * Formatting changes
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
