[ 
https://issues.apache.org/jira/browse/HIVE-22737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092723#comment-17092723
 ] 

Hive QA commented on HIVE-22737:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13001186/HIVE-22737.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 7 failed/errored test(s), 17115 tests 
executed
*Failed tests:*
{noformat}
TestCliDriver - did not produce a TEST-*.xml file (likely timed out) 
(batchId=14)
        
[autogen_colalias.q,nonreserved_keywords_input37.q,cte_join.q,avro_timestamp.q,groupby_ppr.q,correlated_join_keys.q,ppr_pushdown3.q,masking_5.q,input30.q,spark_explain_groupbyshuffle.q,groupby2_map.q,show_create_table_delimited.q,rcfile_null_value.q,join_star.q,columnStatsUpdateForStatsOptimizer_2.q,udf_second.q,skewjoin_union_remove_2.q,udf_size.q,bucketmapjoin_negative3.q,union32.q,timestamp.q,flatten_and_or.q,constant_prop_2.q,parquet_vectorization_17.q,smb_mapjoin_47.q,fold_when.q,udf_mask_hash.q,join18_multi_distinct.q,udf_bitwise_shiftrightunsigned.q,sample8.q]
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[udf_substr] 
(batchId=85)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[udf_substring]
 (batchId=90)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[drop_database_cascade]
 (batchId=45)
org.apache.hive.jdbc.TestJdbcWithLocalClusterSpark.testPermFunc (batchId=219)
org.apache.hive.jdbc.TestJdbcWithMiniHS2.org.apache.hive.jdbc.TestJdbcWithMiniHS2
 (batchId=219)
org.apache.hive.jdbc.TestJdbcWithMiniHS2.testPermFunc (batchId=219)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/21952/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21952/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21952/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 7 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 13001186 - PreCommit-HIVE-Build

> Concurrency: FunctionRegistry::getFunctionInfo is static object locked
> ----------------------------------------------------------------------
>
>                 Key: HIVE-22737
>                 URL: https://issues.apache.org/jira/browse/HIVE-22737
>             Project: Hive
>          Issue Type: Bug
>          Components: Logical Optimizer, UDF
>            Reporter: Gopal Vijayaraghavan
>            Assignee: Ashutosh Chauhan
>            Priority: Major
>         Attachments: FunctionRegistry-lock.png, HIVE-22737.patch
>
>
> The lock is inside a HS2-wide static object
> https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java#L191
> {code}
>   // registry for system functions
>   private static final Registry system = new Registry(true);
> {code}
> And this is the lock itself
> https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java#L332
> {code}
>   public FunctionInfo getFunctionInfo(String functionName) throws 
> SemanticException {
>     lock.lock();
> {code}
>  !FunctionRegistry-lock.png! 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to