[
https://issues.apache.org/jira/browse/HIVE-23295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Attila Magyar updated HIVE-23295:
---------------------------------
Description:
getLiteralList() in SearchArgumentImpl$PredicateLeafImpl returns null if
dynamic values are not available. There are multiple call sites where the
return value is used without a null check. E.g: leaf.getLiteralList().stream().
The return null was added as part of HIVE-18827 to avoid having an unimportant
warning message when dynamic values have not been delivered yet.
[~sershe], [~jdere], I propose return an empty list instead of null in a case
like this.
was:getLiteralList() in SearchArgumentImpl$PredicateLeafImpl returns null if
dynamic values are not available. There are multiple call sites where the
return value is used without a null check. E.g: leaf.getLiteralList().stream().
> Possible NPE when on getting predicate literal list when dynamic values are
> not available
> -----------------------------------------------------------------------------------------
>
> Key: HIVE-23295
> URL: https://issues.apache.org/jira/browse/HIVE-23295
> Project: Hive
> Issue Type: Bug
> Components: storage-api
> Reporter: Attila Magyar
> Assignee: Attila Magyar
> Priority: Major
> Fix For: 4.0.0
>
>
> getLiteralList() in SearchArgumentImpl$PredicateLeafImpl returns null if
> dynamic values are not available. There are multiple call sites where the
> return value is used without a null check. E.g:
> leaf.getLiteralList().stream().
>
> The return null was added as part of HIVE-18827 to avoid having an
> unimportant warning message when dynamic values have not been delivered yet.
>
> [~sershe], [~jdere], I propose return an empty list instead of null in a case
> like this.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
