[
https://issues.apache.org/jira/browse/HIVE-23040?focusedWorklogId=426163&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-426163
]
ASF GitHub Bot logged work on HIVE-23040:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Apr/20 13:57
Start Date: 22/Apr/20 13:57
Worklog Time Spent: 10m
Work Description: aasha commented on a change in pull request #977:
URL: https://github.com/apache/hive/pull/977#discussion_r413006043
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java
##########
@@ -425,11 +432,16 @@ private Long incrementalDump(Path dumpRoot, DumpMetaData
dmd, Path cmRoot, Hive
EventUtils.MSClientNotificationFetcher evFetcher
= new EventUtils.MSClientNotificationFetcher(hiveDb);
+
+ int maxEventLimit = getMaxEventAllowed(work.maxEventLimit());
EventUtils.NotificationEventIterator evIter = new
EventUtils.NotificationEventIterator(
- evFetcher, work.eventFrom, work.maxEventLimit(), evFilter);
+ evFetcher, work.eventFrom, maxEventLimit, evFilter);
Review comment:
If maxEventLimit is not used from repldumpwork, it can be removed from
there
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 426163)
Time Spent: 1h 50m (was: 1h 40m)
> Checkpointing for repl dump incremental phase
> ---------------------------------------------
>
> Key: HIVE-23040
> URL: https://issues.apache.org/jira/browse/HIVE-23040
> Project: Hive
> Issue Type: Improvement
> Reporter: Aasha Medhi
> Assignee: PRAVIN KUMAR SINHA
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-23040.01.patch, HIVE-23040.02.patch,
> HIVE-23040.03.patch, HIVE-23040.04.patch
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
