[
https://issues.apache.org/jira/browse/HIVE-23235?focusedWorklogId=425588&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-425588
]
ASF GitHub Bot logged work on HIVE-23235:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Apr/20 07:13
Start Date: 21/Apr/20 07:13
Worklog Time Spent: 10m
Work Description: aasha commented on a change in pull request #987:
URL: https://github.com/apache/hive/pull/987#discussion_r411930184
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/CopyUtils.java
##########
@@ -383,10 +385,17 @@ private void doRegularCopyOnce(FileSystem sourceFs,
List<Path> srcList,
throw new IOException(e);
}
} else {
+ deleteSubDirs(destinationFs, destination);
FileUtil.copy(sourceFs, paths, destinationFs, destination, false, true,
hiveConf);
}
}
+ private void deleteSubDirs(FileSystem destinationFs, Path destination)
throws IOException {
+ for (FileStatus status : destinationFs.listStatus(destination)) {
Review comment:
We need the destination folder to be present. Thats an extra FS call if
we delete first and recreate again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 425588)
Time Spent: 0.5h (was: 20m)
> Checkpointing in repl dump failing for orc format
> -------------------------------------------------
>
> Key: HIVE-23235
> URL: https://issues.apache.org/jira/browse/HIVE-23235
> Project: Hive
> Issue Type: Bug
> Reporter: Aasha Medhi
> Assignee: Aasha Medhi
> Priority: Major
> Attachments: HIVE-23235.01.patch, HIVE-23235.02.patch,
> HIVE-23235.03.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
