[
https://issues.apache.org/jira/browse/HIVE-23100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085897#comment-17085897
]
Hive QA commented on HIVE-23100:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
49s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
35s{color} | {color:blue} ql in master has 1529 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
53s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
47s{color} | {color:red} ql: The patch generated 110 new + 988 unchanged - 44
fixed = 1098 total (was 1032) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m
47s{color} | {color:red} ql generated 7 new + 1524 unchanged - 5 fixed = 1531
total (was 1529) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
14s{color} | {color:red} The patch generated 2 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 24m 46s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
| | Check for oddness that won't work for negative numbers in
org.apache.hadoop.hive.ql.optimizer.calcite.translator.RexNodeConverter.adjustCaseBranchTypes(List,
RelDataType, RexBuilder) At RexNodeConverter.java:work for negative numbers
in
org.apache.hadoop.hive.ql.optimizer.calcite.translator.RexNodeConverter.adjustCaseBranchTypes(List,
RelDataType, RexBuilder) At RexNodeConverter.java:[line 409] |
| | Check for oddness that won't work for negative numbers in
org.apache.hadoop.hive.ql.optimizer.calcite.translator.RexNodeConverter.rewriteCaseChildren(String,
List, RexBuilder) At RexNodeConverter.java:work for negative numbers in
org.apache.hadoop.hive.ql.optimizer.calcite.translator.RexNodeConverter.rewriteCaseChildren(String,
List, RexBuilder) At RexNodeConverter.java:[line 375] |
| | Dead store to inputPosMap in
org.apache.hadoop.hive.ql.parse.CalcitePlanner$CalcitePlannerAction.genLateralViewPlans(ASTNode,
Map) At
CalcitePlanner.java:org.apache.hadoop.hive.ql.parse.CalcitePlanner$CalcitePlannerAction.genLateralViewPlans(ASTNode,
Map) At CalcitePlanner.java:[line 3389] |
| | Exception is caught when Exception is not thrown in
org.apache.hadoop.hive.ql.parse.type.HiveFunctionHelper.getWindowAggregateFunctionInfo(boolean,
boolean, String, List) At HiveFunctionHelper.java:is not thrown in
org.apache.hadoop.hive.ql.parse.type.HiveFunctionHelper.getWindowAggregateFunctionInfo(boolean,
boolean, String, List) At HiveFunctionHelper.java:[line 425] |
| | Boxing/unboxing to parse a primitive
org.apache.hadoop.hive.ql.parse.type.RexNodeExprFactory.createBigintConstantExpr(String)
At
RexNodeExprFactory.java:org.apache.hadoop.hive.ql.parse.type.RexNodeExprFactory.createBigintConstantExpr(String)
At RexNodeExprFactory.java:[line 213] |
| | Boxing/unboxing to parse a primitive
org.apache.hadoop.hive.ql.parse.type.RexNodeExprFactory.createIntConstantExpr(String)
At
RexNodeExprFactory.java:org.apache.hadoop.hive.ql.parse.type.RexNodeExprFactory.createIntConstantExpr(String)
At RexNodeExprFactory.java:[line 224] |
| | org.apache.hadoop.hive.ql.parse.type.RexNodeExprFactory$HiveNlsString
doesn't override org.apache.calcite.util.NlsString.equals(Object) At
RexNodeExprFactory.java:At RexNodeExprFactory.java:[line 1] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-21724/dev-support/hive-personality.sh
|
| git revision | master / 51dda9a |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-21724/yetus/diff-checkstyle-ql.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-21724/yetus/new-findbugs-ql.html
|
| asflicense |
http://104.198.109.242/logs//PreCommit-HIVE-Build-21724/yetus/patch-asflicense-problems.txt
|
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-21724/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> Create RexNode factory and use it in CalcitePlanner
> ---------------------------------------------------
>
> Key: HIVE-23100
> URL: https://issues.apache.org/jira/browse/HIVE-23100
> Project: Hive
> Issue Type: Improvement
> Components: CBO
> Reporter: Jesus Camacho Rodriguez
> Assignee: Jesus Camacho Rodriguez
> Priority: Major
> Attachments: HIVE-23100.01.patch, HIVE-23100.02.patch,
> HIVE-23100.03.patch, HIVE-23100.04.patch, HIVE-23100.05.patch,
> HIVE-23100.06.patch, HIVE-23100.07.patch, HIVE-23100.08.patch,
> HIVE-23100.09.patch, HIVE-23100.10.patch, HIVE-23100.patch
>
>
> Follow-up of HIVE-22746.
> This will allow us to generate directly the RexNode from the AST nodes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
