[ 
https://issues.apache.org/jira/browse/HIVE-22165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083635#comment-17083635
 ] 

Hive QA commented on HIVE-22165:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12999870/HIVE-22165.02.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 17423 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/21639/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21639/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21639/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12999870 - PreCommit-HIVE-Build

> Synchronisation introduced by HIVE-14296 on SessionManager.closeSession 
> causes high latency in a busy hive server
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-22165
>                 URL: https://issues.apache.org/jira/browse/HIVE-22165
>             Project: Hive
>          Issue Type: Bug
>          Components: HiveServer2
>    Affects Versions: 2.1.0, 2.3.2
>            Reporter: Amruth Sampath
>            Assignee: Amruth Sampath
>            Priority: Major
>         Attachments: HIVE-22165.02.patch, HIVE-22165.02.patch, 
> HIVE-22165.patch, HIVE-22165.patch.1
>
>
> HIVE-14296 introduces this 
> [commit|https://github.com/apache/hive/commit/477a47d3b4b9e3da3c22465217c2024588f7f000]
>  which adds synchronization to SessionManager.closeSession.
> And it looks like it is used only for logging purposes.
> In a busy hive server where 5-10 sessions are created closed every second, an 
> increase in latency of any other downstream services (Zk, HDFS) causes a 
> queueing effect (lot of threads getting blocked on 
> SessionManager.closeSession) creating an induced latency of 3-5 minutes at 
> times for just closing the session. 
> Since the gauge (MetricsConstant.HS2_OPEN_SESSIONS) is already tracking the 
> open session counts, the synchronization (along with the additional logging) 
> can be removed without any functionality losses.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to