[
https://issues.apache.org/jira/browse/HIVE-23166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17081916#comment-17081916
]
Hive QA commented on HIVE-23166:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12999699/HIVE-23166.03.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 18212 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/21590/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21590/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21590/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12999699 - PreCommit-HIVE-Build
> Guard VGB from flushing too often
> ---------------------------------
>
> Key: HIVE-23166
> URL: https://issues.apache.org/jira/browse/HIVE-23166
> Project: Hive
> Issue Type: Improvement
> Components: llap
> Affects Versions: 4.0.0
> Reporter: Panagiotis Garefalakis
> Assignee: Panagiotis Garefalakis
> Priority: Major
> Attachments: HIVE-23166.01.patch, HIVE-23166.02.patch,
> HIVE-23166.03.patch
>
>
> The existing flush logic in our VectorGroupByOperator is completely static.
> It depends on the: number of HtEntries
> (*hive.vectorized.groupby.maxentries*) and the MAX memory threshold (by
> default 90% of available memory)
>
> Assuming that we are not memory constrained the periodicity of flushing is
> currently dictated by the static number of entries (1M by default) which can
> be also misconfigured to a very low value.
> I am proposing along with maxHtEntries, to also take into account current
> memory usage, to avoid flushing too ofter as it can hurt op throughput for
> particular workloads.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
