[ 
https://issues.apache.org/jira/browse/HIVE-23139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17076168#comment-17076168
 ] 

László Bodor commented on HIVE-23139:
-------------------------------------

+1 
as you need to upload a new patch because of testExecuteImmediate anyway, 
please put a comment before maskIfStartsWith noting that string operations are 
much faster, otherwise somebody will try to refactor it back to regexes sooner 
or later (e.g. because 1 regex array looks better than more arrays...however, 
we care performance more)

> Improve q test result masking
> -----------------------------
>
>                 Key: HIVE-23139
>                 URL: https://issues.apache.org/jira/browse/HIVE-23139
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Hive
>            Reporter: Miklos Gergely
>            Assignee: Miklos Gergely
>            Priority: Major
>         Attachments: HIVE-23139.01.patch
>
>
> Q Test result masking can take a long time, in extreme cases up to 5 times as 
> much as the test itself, because it is inefficient. Use contains, startsWith 
> instead of patterns for masking lines containing or starting with specified 
> strings.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to