[
https://issues.apache.org/jira/browse/HIVE-23118?focusedWorklogId=415070&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-415070
]
ASF GitHub Bot logged work on HIVE-23118:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Apr/20 21:48
Start Date: 02/Apr/20 21:48
Worklog Time Spent: 10m
Work Description: jcamachor commented on pull request #966: HIVE-23118:
Option for exposing compile time counters as tez counters
URL: https://github.com/apache/hive/pull/966#discussion_r402615414
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/TezJobMonitor.java
##########
@@ -185,6 +188,12 @@ public int monitorExecution() {
if (wmContext != null) {
Set<String> desiredCounters = wmContext.getSubscribedCounters();
TezCounters dagCounters = status.getDAGCounters();
+ // if initial counters exists, merge it with dag counters to get
aggregated view
Review comment:
Can we move this if block to a utility static function `mergeCounters`? It
seems it is repeated in a couple of places, may be useful in other cases in the
future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 415070)
Time Spent: 20m (was: 10m)
> Option for exposing compile time counters as tez counters
> ---------------------------------------------------------
>
> Key: HIVE-23118
> URL: https://issues.apache.org/jira/browse/HIVE-23118
> Project: Hive
> Issue Type: Improvement
> Reporter: Prasanth Jayachandran
> Assignee: Prasanth Jayachandran
> Priority: Minor
> Labels: pull-request-available
> Attachments: HIVE-23118.1.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> TezCounters currently are runtime only. Some compile time information from
> optimizer can be exposed as counters which can then be used by workload
> management to make runtime decisions.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
