[jira] [Commented] (HIVE-23032) Add batching in Lock generation

[Peter Vary (Jira)]

    [ 
https://issues.apache.org/jira/browse/HIVE-23032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17068017#comment-17068017
 ] 

Peter Vary commented on HIVE-23032:
-----------------------------------

{code}
                  if (intLockId % batchSize != 0) {
                    pstmt.executeBatch();
                  }
{code}

should be, since intLockId incremented since the previous check:
{code}
                  if ((intLockId - 1) % batchSize != 0) {
                    pstmt.executeBatch();
                  }
{code}

I did the same mistake in my batching patch, but luckily I had a test with 
enough transactions to show me my error :)



> Add batching in Lock generation
> -------------------------------
>
>                 Key: HIVE-23032
>                 URL: https://issues.apache.org/jira/browse/HIVE-23032
>             Project: Hive
>          Issue Type: Improvement
>          Components: Locking
>            Reporter: Denys Kuzmenko
>            Assignee: Denys Kuzmenko
>            Priority: Major
>         Attachments: HIVE-23032.1.patch, HIVE-23032.2.patch, 
> HIVE-23032.3.patch, HIVE-23032.4.patch, HIVE-23032.5.patch, 
> HIVE-23032.6.patch, HIVE-23032.7.patch, HIVE-23032.8.patch
>
>
> Replace multi-row insert in Oracle with batching. Performance tests showed 
> significant performance improvement after turning batching on.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)