[ https://issues.apache.org/jira/browse/HIVE-23051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17066937#comment-17066937 ]
Hive QA commented on HIVE-23051: -------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m 18s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 59s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 39s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 40s{color} | {color:blue} ql in master has 1531 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 53s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 23s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 3s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 3s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 40s{color} | {color:red} ql: The patch generated 1 new + 1 unchanged - 7 fixed = 2 total (was 8) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 56s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 56s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 14s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 24m 13s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-21266/dev-support/hive-personality.sh | | git revision | master / 3c42258 | | Default Java | 1.8.0_111 | | findbugs | v3.0.1 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-21266/yetus/diff-checkstyle-ql.txt | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-21266/yetus.txt | | Powered by | Apache Yetus http://yetus.apache.org | This message was automatically generated. > Clean up BucketCodec > -------------------- > > Key: HIVE-23051 > URL: https://issues.apache.org/jira/browse/HIVE-23051 > Project: Hive > Issue Type: Improvement > Reporter: David Mollitor > Assignee: David Mollitor > Priority: Major > Attachments: HIVE-23051.1.patch, HIVE-23051.2.patch, > HIVE-23051.3.patch > > > A couple of nagging things caught my eye with this class. The first thing: > {code:java|title=BucketCodec.java} > int statementId = options.getStatementId() >= 0 ? > options.getStatementId() : 0; > assert this.version >=0 && this.version <= MAX_VERSION > : "Version out of range: " + version; > if(!(options.getBucketId() >= 0 && options.getBucketId() <= > MAX_BUCKET_ID)) { > throw new IllegalArgumentException("bucketId out of range: " + > options.getBucketId()); > } > if(!(statementId >= 0 && statementId <= MAX_STATEMENT_ID)) { > throw new IllegalArgumentException("statementId out of range: " + > statementId); > } > {code} > {{statementId}} gets capped, if it's less than 0, then it gets rounded up to > 0. However, it later checks that the {{statementId}} is greater,... which is > will always be 'true' since it's getting rounded. > # Remove the rounding behavior. > # Make better error message > # Fail-fast in the constructor if the version is invalid -- This message was sent by Atlassian Jira (v8.3.4#803005)