[
https://issues.apache.org/jira/browse/HIVE-23064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17064483#comment-17064483
]
David Mollitor commented on HIVE-23064:
---------------------------------------
[~pvary] Thanks for the review!!
# If you look in that class, there are plenty of examples in that method that
use SLF4J and not console. I don't think beeline calls this code at all, I'm
pretty sure it's called in HS2 in reaction to a SQL statement sent by the
client. This logging was probably related to HiveCLI, but I believe that is
removed/deprecated in Hive 4.0
# It does not make any sense at all to swallow the Exception here. This
try/catch code was probably an artifact of an IDE auto generation. If you
look, two lines later, if the Exception is swallowed, {{fstat}} will be 'null'
and it will throw a NPE. That would suck to troubleshoot.
# I agree with you. That does not make any sense to me. I can create a
separate ticket for that. It is outside the scope of this particular JIRA.
> Remove Calls to printStackTrace in Module hive-exec
> ---------------------------------------------------
>
> Key: HIVE-23064
> URL: https://issues.apache.org/jira/browse/HIVE-23064
> Project: Hive
> Issue Type: Sub-task
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Major
> Attachments: HIVE-23064.1.patch
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
