[ https://issues.apache.org/jira/browse/HIVE-23042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17063114#comment-17063114 ]
Hive QA commented on HIVE-23042: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12997134/HIVE-23042.3.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 89 failed/errored test(s), 18123 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.metastore.client.TestAddPartitions.addPartitionOtherCatalog[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.noSuchCatalog[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionAlreadyExists[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionDifferentNamesAndTypesInColAndTableCol[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionEmptyColsInSd[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionEmptyDb[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionEmptyLocation[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionEmptySerdeInfo[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionEmptyTable[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionEmptyValue[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionForExternalTableNullLocation[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionForExternalTable[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionForView[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionInvalidColTypeInSd[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionMorePartColInTable[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionNoColInPartition[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionNoPartColOnTable[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionNoValueInPartition[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionNonExistingDb[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionNonExistingTable[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionNullAndEmptyLocation[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionNullColNameInSd[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionNullColTypeInSd[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionNullColsInSd[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionNullDb[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionNullLocationInTableToo[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionNullLocation[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionNullPartition[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionNullSd[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionNullTable[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionNullValues[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionSetInvalidLocation[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionTooManyValues[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionTwoValues[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionUpperCaseDBAndTableName[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionUpperCase[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionWithDefaultAttributes[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartition[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionsAlreadyExists[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionsDifferentDBs[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionsDifferentTable[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionsDuplicateInTheList[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionsEmptyColsInSd[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionsEmptyDb[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionsEmptyList[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionsEmptySerdeInfo[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionsEmptyTable[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionsEmptyValue[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionsForExternalTableNullLocation[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionsForExternalTable[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionsForViewNullPartLocation[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionsForViewNullPartSd[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionsForView[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionsInvalidColTypeInSd[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionsInvalidLocation[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionsMorePartColInTable[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionsMoreThanThreadCountsOneFails[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionsMultipleValues[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionsNoValueInPartition[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionsNonExistingDb[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionsNonExistingTable[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionsNullColNameInSd[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionsNullColTypeInSd[Embedded] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionsNullColTypeInSd[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionsNullColsInSd[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionsNullDb[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionsNullList[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionsNullLocationInTableToo[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionsNullPartition[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionsNullSd[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionsNullTable[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionsNullValues[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionsOneInvalid[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionsUpperCaseDBAndTableNameInOnePart[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionsUpperCaseDBAndTableName[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionsWithDefaultAttributes[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionsWithSameNameCaseSensitive[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitionsWithSameNameInTheListCaseSensitive[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartitions[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartsAlreadyExistsIfExistsTrue[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartsAlreadyExists[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartsDifferentDBs[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartsDifferentTable[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartsDuplicateInTheList[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartsEmptyList[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartsMultipleValues[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartsNullList[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddPartsNullPartition[Remote] (batchId=230) org.apache.hadoop.hive.metastore.client.TestAddPartitions.testAddParts[Remote] (batchId=230) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/21188/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21188/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21188/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 89 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12997134 - PreCommit-HIVE-Build > Merge queries to a single one for updating MIN_OPEN_TXNS table > -------------------------------------------------------------- > > Key: HIVE-23042 > URL: https://issues.apache.org/jira/browse/HIVE-23042 > Project: Hive > Issue Type: Bug > Components: Transactions > Reporter: Peter Vary > Assignee: Peter Vary > Priority: Major > Attachments: HIVE-23042.2.patch, HIVE-23042.3.patch, HIVE-23042.patch > > > When opening a new transaction we issue 2 queries to update the MIN_OPEN_TXN > table. > {code} > <SELECT MIN("TXN_ID") FROM "TXNS" WHERE "TXN_STATE" = 'o'> > <insert into "MIN_HISTORY_LEVEL" ("MHL_TXNID", "MHL_MIN_OPEN_TXNID") > values(763, 763)> > {code} > This could be archived with a single query faster, if we do not open > transactions in batch, like: > {code} > <INSERT INTO "MIN_HISTORY_LEVEL" ("MHL_TXNID", "MHL_MIN_OPEN_TXNID") > SELECT ?, MIN("TXN_ID") FROM "TXNS" WHERE "TXN_STATE" = 'o'> > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)