[ 
https://issues.apache.org/jira/browse/HIVE-11778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14741880#comment-14741880
 ] 

Gunther Hagleitner commented on HIVE-11778:
-------------------------------------------

[~xuefuz] Thanks for the clarification. As far as I can tell you can only get 
the current implementation by setting USE_DEPRECATED_CLI as an environment 
variable. I don't think it makes sense to deprecate and switch the default 
before the gaps are closed.

You also haven't addressed [~sershe]'s concern. It's aggressive to make this 
the default if you don't have any tests for the beeline CLI in HiveQA. I think 
this is also a prereq for calling it the default.

The other thing is performance. I can't tell from the perf jira what was 
actually measured (pure retrieval? startup? query completion?) and the numbers 
are really small (1 time 500 rows? in .9s) to be conclusive. Even then it's 
showing a 10% degradation. I don't think this is complete.

If you want to leave the old implementation the default until these things are 
addressed, I have no problem. Otherwise I'm am still against merging this.

> Merge beeline-cli branch to trunk
> ---------------------------------
>
>                 Key: HIVE-11778
>                 URL: https://issues.apache.org/jira/browse/HIVE-11778
>             Project: Hive
>          Issue Type: Sub-task
>          Components: CLI
>    Affects Versions: 2.0.0
>            Reporter: Ferdinand Xu
>            Assignee: Ferdinand Xu
>         Attachments: HIVE-11778.patch
>
>
> The team working on the beeline-cli branch would like to merge their work to 
> trunk. This jira will track that effort.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to