[ https://issues.apache.org/jira/browse/HIVE-21164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059491#comment-17059491 ]
Sungwoo commented on HIVE-21164: -------------------------------- Hello Marta, I wonder if you have a plan to try to reproduce the wrong result before starting to debug. While I have a good reason to believe that it is a bug due to this patch, there is also a very slight chance that it is a bug on my side because I used a different execution engine (MR3) in my testing. The reason I believe that it is a bug due to this patch is: 1. With the previous commit made just before this commit, ORC tables are created okay without any issue. 2. While I don't understand exactly how this commit works, it deals with inserting data to existing tables and contains no code specific to execution engines. 3. Although we use an execution engine different from Tez or LLAP, it does not affect the compilation in HiveServer2. So, I wonder if you or your team are going to try to reproduce the wrong result. I will also try to find a small example that produces the same result. Regards, --- Sungwoo Park On Sun, Mar 15, 2020 at 12:54 AM Marta Kuczora (Jira) <j...@apache.org> > ACID: explore how we can avoid a move step during inserts/compaction > -------------------------------------------------------------------- > > Key: HIVE-21164 > URL: https://issues.apache.org/jira/browse/HIVE-21164 > Project: Hive > Issue Type: Bug > Components: Transactions > Affects Versions: 3.1.1 > Reporter: Vaibhav Gumashta > Assignee: Marta Kuczora > Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-21164.1.patch, HIVE-21164.10.patch, > HIVE-21164.11.patch, HIVE-21164.11.patch, HIVE-21164.12.patch, > HIVE-21164.13.patch, HIVE-21164.14.patch, HIVE-21164.14.patch, > HIVE-21164.15.patch, HIVE-21164.16.patch, HIVE-21164.17.patch, > HIVE-21164.18.patch, HIVE-21164.19.patch, HIVE-21164.2.patch, > HIVE-21164.20.patch, HIVE-21164.21.patch, HIVE-21164.22.patch, > HIVE-21164.3.patch, HIVE-21164.4.patch, HIVE-21164.5.patch, > HIVE-21164.6.patch, HIVE-21164.7.patch, HIVE-21164.8.patch, HIVE-21164.9.patch > > > Currently, we write compacted data to a temporary location and then move the > files to a final location, which is an expensive operation on some cloud file > systems. Since HIVE-20823 is already in, it can control the visibility of > compacted data for the readers. Therefore, we can perhaps avoid writing data > to a temporary location and directly write compacted data to the intended > final path. -- This message was sent by Atlassian Jira (v8.3.4#803005)