[ https://issues.apache.org/jira/browse/HIVE-23017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059179#comment-17059179 ]
Hive QA commented on HIVE-23017: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12996664/HIVE-23017.1.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 18099 tests executed *Failed tests:* {noformat} org.apache.hive.beeline.TestBeeLineWithArgs.testEmbeddedBeelineOutputs (batchId=286) org.apache.hive.service.cli.operation.TestOperationLoggingAPIWithMr.testFetchResultsOfLogWithExecutionMode (batchId=289) org.apache.hive.service.cli.operation.TestOperationLoggingAPIWithMr.testFetchResultsOfLogWithPerformanceMode (batchId=289) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/21109/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21109/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21109/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 3 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12996664 - PreCommit-HIVE-Build > Use Inherited Logger in Tasks > ----------------------------- > > Key: HIVE-23017 > URL: https://issues.apache.org/jira/browse/HIVE-23017 > Project: Hive > Issue Type: Improvement > Reporter: David Mollitor > Assignee: David Mollitor > Priority: Minor > Attachments: HIVE-23017.1.patch > > > {code:java|title=FetchTask} > public class FetchTask extends Task<FetchWork> implements Serializable { > private static final long serialVersionUID = 1L; > private int maxRows = 100; > private FetchOperator fetch; > private ListSinkOperator sink; > private int totalRows; > private static transient final Logger LOG = > LoggerFactory.getLogger(FetchTask.class); > JobConf job = null; > {code} > The Tasks class is base class for many other. Cleaner to simply make the > {{Logger}} {{protected}} and usable by other classes. -- This message was sent by Atlassian Jira (v8.3.4#803005)