[
https://issues.apache.org/jira/browse/HIVE-22940?focusedWorklogId=400802&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-400802
]
ASF GitHub Bot logged work on HIVE-22940:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Mar/20 16:12
Start Date: 10/Mar/20 16:12
Worklog Time Spent: 10m
Work Description: kgyrtkirk commented on pull request #930: HIVE-22940
datasketches functions
URL: https://github.com/apache/hive/pull/930#discussion_r390434617
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/exec/DataSketchesFunctions.java
##########
@@ -0,0 +1,218 @@
+package org.apache.hadoop.hive.ql.exec;
+
+import org.apache.hadoop.hive.ql.udf.generic.GenericUDAFResolver2;
+import org.apache.hadoop.hive.ql.udf.generic.GenericUDTF;
+
+public class DataSketchesFunctions {
+
+ private static final String DATA_TO_SKETCH = "datatosketch";
Review comment:
the final name of the method is:
* `ds_theta_gen_sketch`
* `ds_theta_to_sketch`
* `ds_theta_build_sketch`
* `ds_theta_build`
* `ds_theta_sketch`
I right now feel these last 2 the best; they are easy to remember and the
naming of these methods will be structured anyway - so the `ds_theta_` prefix
somewhat adds a context for the function we may not need to repeat "sketch"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 400802)
Time Spent: 1h 40m (was: 1.5h)
> Make the datasketches functions available as predefined functions
> ------------------------------------------------------------------
>
> Key: HIVE-22940
> URL: https://issues.apache.org/jira/browse/HIVE-22940
> Project: Hive
> Issue Type: Sub-task
> Reporter: Zoltan Haindrich
> Assignee: Zoltan Haindrich
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22940.01.patch, HIVE-22940.02.patch
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
