[ https://issues.apache.org/jira/browse/HIVE-22978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17055852#comment-17055852 ]
Hive QA commented on HIVE-22978: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12996233/HIVE-22978.02.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 18093 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/21049/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21049/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21049/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12996233 - PreCommit-HIVE-Build > Fix decimal precision and scale inference for aggregate rewriting in Calcite > ---------------------------------------------------------------------------- > > Key: HIVE-22978 > URL: https://issues.apache.org/jira/browse/HIVE-22978 > Project: Hive > Issue Type: Bug > Components: CBO > Reporter: Jesus Camacho Rodriguez > Assignee: Jesus Camacho Rodriguez > Priority: Major > Labels: pull-request-available > Attachments: HIVE-22978.01.patch, HIVE-22978.02.patch, > HIVE-22978.patch > > Time Spent: 40m > Remaining Estimate: 0h > > Calcite rules can do rewritings of aggregate functions, e.g., {{avg}} into > {{sum/count}}. When type of {{avg}} is decimal, inference of intermediate > precision and scale for the division is not done correctly. The reason is > that we miss support for some types in method {{getDefaultPrecision}} in > {{HiveTypeSystemImpl}}. Additionally, {{deriveSumType}} should be overridden > in {{HiveTypeSystemImpl}} to abide by the Hive semantics for sum aggregate > type inference. -- This message was sent by Atlassian Jira (v8.3.4#803005)