[ https://issues.apache.org/jira/browse/HIVE-22985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17053569#comment-17053569 ]
Hive QA commented on HIVE-22985: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12995738/HIVE-22985.01.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 18102 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/20980/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20980/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20980/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12995738 - PreCommit-HIVE-Build > Failed compaction always throws TxnAbortedException > --------------------------------------------------- > > Key: HIVE-22985 > URL: https://issues.apache.org/jira/browse/HIVE-22985 > Project: Hive > Issue Type: Bug > Reporter: Karen Coppage > Assignee: Karen Coppage > Priority: Major > Labels: compaction > Attachments: HIVE-22985.01.patch > > > If compaction fails, its txn is aborted, however Worker attempts to commit it > again in a finally statement. This results in a TxnAbortedException [1] > thrown from TxnHandler#commitTxn > We need to add a check and only try to commit at the end if the txn is not > aborted.(TxnHandler#commitTxn does nothing if txn is already committed.) > [1] > {code:java} > ERROR org.apache.hadoop.hive.metastore.RetryingHMSHandler - > TxnAbortedException(message:Transaction txnid:16 already aborted) > at > org.apache.hadoop.hive.metastore.txn.TxnHandler.raiseTxnUnexpectedState(TxnHandler.java:4843) > at > org.apache.hadoop.hive.metastore.txn.TxnHandler.commitTxn(TxnHandler.java:1141) > at > org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.commit_txn(HiveMetaStore.java:8101) > ... > at > org.apache.hadoop.hive.ql.txn.compactor.Worker.commitTxn(Worker.java:291) > at org.apache.hadoop.hive.ql.txn.compactor.Worker.run(Worker.java:269) > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)