[
https://issues.apache.org/jira/browse/HIVE-11645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14739388#comment-14739388
]
Prasanth Jayachandran commented on HIVE-11645:
----------------------------------------------
The patch mostly looks good.
{code}
Loaded : 199/199 partitions.
Time taken for load dynamic partitions : 9.471 seconds.
Time taken for adding to write entity : 29
{code}
Time unit for write entity is still missing.
Minor nit: Can you remove the space before ":" and full stop at the ends (to
make it consistent). Also can you leave a line before "Loaded" string. It looks
close to summary table.
{code}
VERTICES TOTAL_TASKS FAILED_ATTEMPTS KILLED_TASKS DURATION_SECONDS
CPU_TIME_MILLIS GC_TIME_MILLIS INPUT_RECORDS OUTPUT_RECORDS
Map 1 1 0 0 13.29
0 3,472 13,056 0
Loaded : 199/199 partitions.
{code}
Other than these minor cosmetic tweaks the patch LGTM, +1.
> Add in-place updates for dynamic partitions loading
> ---------------------------------------------------
>
> Key: HIVE-11645
> URL: https://issues.apache.org/jira/browse/HIVE-11645
> Project: Hive
> Issue Type: Improvement
> Components: CLI
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Attachments: HIVE-11645.2.patch, HIVE-11645.2.patch,
> HIVE-11645.3.patch, HIVE-11645.4.patch, HIVE-11645.patch
>
>
> Currently, updates go to log file and on console there is no visible progress.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
