[
https://issues.apache.org/jira/browse/HIVE-22872?focusedWorklogId=395697&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-395697
]
ASF GitHub Bot logged work on HIVE-22872:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Mar/20 01:35
Start Date: 02/Mar/20 01:35
Worklog Time Spent: 10m
Work Description: jcamachor commented on pull request #924: HIVE-22872
schq executors
URL: https://github.com/apache/hive/pull/924#discussion_r386162395
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/scheduled/ScheduledQueryExecutionService.java
##########
@@ -73,41 +89,42 @@ public static ScheduledQueryExecutionService
startScheduledQueryExecutorService(
private ScheduledQueryExecutionService(ScheduledQueryExecutionContext ctx) {
context = ctx;
- ctx.executor.submit(worker = new ScheduledQueryExecutor());
+ ctx.executor.submit(poller = new ScheduledQueryPoller());
ctx.executor.submit(new ProgressReporter());
}
static boolean isTerminalState(QueryState state) {
return state == QueryState.FINISHED || state == QueryState.FAILED;
}
- class ScheduledQueryExecutor implements Runnable {
-
- private ScheduledQueryProgressInfo info;
+ class ScheduledQueryPoller implements Runnable {
Review comment:
Can we leave a comment with high level purpose of the Poller class? Also,
probably mentioning that there should be only one-at-the-time per HS2.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 395697)
Time Spent: 40m (was: 0.5h)
> Support multiple executors for scheduled queries
> ------------------------------------------------
>
> Key: HIVE-22872
> URL: https://issues.apache.org/jira/browse/HIVE-22872
> Project: Hive
> Issue Type: Improvement
> Reporter: Zoltan Haindrich
> Assignee: Zoltan Haindrich
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22872.01.patch, HIVE-22872.02.patch,
> HIVE-22872.03.patch, HIVE-22872.04.patch, HIVE-22872.05.patch,
> HIVE-22872.06.patch
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
