[ 
https://issues.apache.org/jira/browse/HIVE-22925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17047880#comment-17047880
 ] 

Hive QA commented on HIVE-22925:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12994864/HIVE-22925.3.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 18076 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/20873/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20873/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20873/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12994864 - PreCommit-HIVE-Build

> Implement TopNKeyFilter efficiency check
> ----------------------------------------
>
>                 Key: HIVE-22925
>                 URL: https://issues.apache.org/jira/browse/HIVE-22925
>             Project: Hive
>          Issue Type: Bug
>          Components: Hive
>            Reporter: Attila Magyar
>            Assignee: Attila Magyar
>            Priority: Major
>             Fix For: 4.0.0
>
>         Attachments: HIVE-22925.1.patch, HIVE-22925.2.patch, 
> HIVE-22925.3.patch
>
>
> In certain cases the TopNKey filter might work in an inefficient way and adds 
> extra CPU overhead. For example if the rows are coming in an descending order 
> but the filter wants the top N smallest elements the filter will forward 
> everything.
> Inefficient should be detected in runtime so that the filter can be disabled 
> of the ration between forwarder_rows/total_rows is too high.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to