[ https://issues.apache.org/jira/browse/HIVE-22763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17043807#comment-17043807 ]
Hive QA commented on HIVE-22763: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12994309/HIVE-22763.03.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 18057 tests executed *Failed tests:* {noformat} org.apache.hive.jdbc.TestTriggersNoTezSessionPool.testTriggerDAGTotalTasks (batchId=290) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/20805/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20805/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20805/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12994309 - PreCommit-HIVE-Build > 0 is accepted in 12-hour format during timestamp cast > ----------------------------------------------------- > > Key: HIVE-22763 > URL: https://issues.apache.org/jira/browse/HIVE-22763 > Project: Hive > Issue Type: Bug > Components: HiveServer2 > Reporter: Karen Coppage > Assignee: Karen Coppage > Priority: Minor > Fix For: 4.0.0 > > Attachments: HIVE-22763.01.patch, HIVE-22763.01.patch, > HIVE-22763.01.patch, HIVE-22763.01.patch, HIVE-22763.01.patch, > HIVE-22763.01.patch, HIVE-22763.02.patch, HIVE-22763.03.patch > > > Having a timestamp string in 12-hour format can be parsed if the hour is 0, > however, based on the [design > document|https://docs.google.com/document/d/1V7k6-lrPGW7_uhqM-FhKl3QsxwCRy69v2KIxPsGjc1k/edit], > it should be rejected. > h3. How to reproduce > Run {code}select cast("2020-01-01 0 am 00" as timestamp format "yyyy-mm-dd > hh12 p.m. ss"){code} > It shouldn' t be parsed, as the hour component is 0. > h3. Spec > ||Pattern||Meaning||Additional details|| > |HH12|Hour of day (1-12)|Same as HH| > |HH|Hour of day (1-12)|{panel:borderStyle=none} > - One digit inputs are possible in a string to datetime conversion but needs > to be surrounded by separators. > - In a datetime to string conversion one digit hours are prefixed with a zero. > - Error if provided hour is not between 1 and 12. > - Displaying an unformatted timestamp in Impala uses the HH24 format > regardless if it was created using HH12. > - If no AM/PM provided then defaults to AM. > - In string to datetime conversion, conflicts with SSSSS and > HH24.{panel:borderStyle=none}| -- This message was sent by Atlassian Jira (v8.3.4#803005)